Make optional ssoConfig fields nullable #1752
Conversation
|
@eliykat Does this mean we reset the values if a user switches between SAML and OpenID? I suspect it's a fairly rare scenario, but currently we don't reset them when switching between, so you could in theory have two working configs that you can easily switch between. |
|
Yes that's correct. This PR will change the current behaviour so that you can only store 1 config at a time. I did discuss it with Jordan (who deals directly with users to troubleshoot SSO issues) and we couldn't identify any need for the current behaviour - i.e. we do not think there is a use case for having 2 different SSO configs and switching between them in production. It's also contrary to the form design, which presents the two options as either-or. I suspect that users do not currently expect the non-selected SSO type to be saved. |
Type of change
Objective
Required to support bitwarden/web#1332. Because we disable the inactive SSO fields (e.g. disable SAML if configuring OpenId), that field data is not sent to the server. This is a slight change in behaviour, as previously you could save both an OpenId and SAML configuration and switch between them. However, after discussing with Jordan, we were unable to identify a use case for this. I assume it's probably an unintended side-effect of using template forms.
Most types are nullable by default, we just need to make the
bools nullable and then callgetValueOrDefault()when mapping it over to the data model.Before you submit