Improve SSO Config validation #1879
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Further changes required for bitwarden/web#1332.
As discussed here, we now set the SSO configuration defaults in the client-side form, instead of constructing an empty
SsoConfigurationDataclass with defaults and sending it to the client. This PR removes the server-side defaults to avoid confusion about where they're set.Code changes
Dataproperty null instead of constructing an object with default values.staticmethods. This is required now that we may not have anSsoConfigurationDatainstance in some cases. They actually didn't use any instantiated class properties, so this is more accurate anyway.Testing requirements
See main ticket
Before you submit
dotnet tool run dotnet-format --check) (required)