Conversation
| from .compute.mongo import * | ||
| with ignoring(ImportError): | ||
| from .pytables import * | ||
| from .compute.pytables import * |
There was a problem hiding this comment.
This probably improves things enormously wrt import times:
In [1]: %time import blaze as bz
Wall time: 4.6 sI had wondered if some sort of lazy import mechanism might be useful, but with this change perhaps not?
If there's a plugin mechanism for backends though it may still be useful so users don't have to pay for what they're not using.
There was a problem hiding this comment.
@dhirschfeld I haven't thought about how the backends should be installed. I was thinking of just making it a separate import:
import blaze
import blaze_mongo
which makes it explicit and solve the import times.
There was a problem hiding this comment.
I had thought to use the setuptools plugin capability but your solution is simpler and more explicit!
|
pandas-msgpack, which blaze server depends on, is a blocker since that package isn't capable with newer pandas. I made a quick fix but tests on that are failing for one of the builds. |
|
@postelrich any update on the compatibility of |
|
Nope not working on this.
…On Tue, Oct 30, 2018, 2:33 PM lia-simeone ***@***.***> wrote:
@postelrich <https://github.com/postelrich> any update on the
compatibility of pandas-msgpack?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1671 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ADc8JJt5EGG1kxlhhssFJd6r6HYLZqzyks5uqJuIgaJpZM4VnjNB>
.
|
Resolves #1670
This PR removes non-core backends from the blaze package.