MB-61890 - Introducing config for zap layer#2066
Merged
Merged
Conversation
de21e72 to
4030e93
Compare
4030e93 to
4a9ce7c
Compare
Member
abhinavdangeti
left a comment
There was a problem hiding this comment.
It seems this commit makes it clear that you'll need to introduce new APIs (blevesearch/zapx#256) to all versions of zapx.
CascadingRadium
previously approved these changes
Feb 4, 2026
Member
abhinavdangeti
left a comment
There was a problem hiding this comment.
Looks fine, but let's wait to get all the zapx version commits in before we take this.
abhinavdangeti
approved these changes
Feb 4, 2026
capemox
reviewed
Feb 11, 2026
capemox
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
segmentConfigthat can be used to pass index specific config values for the zap level. This would help in the future to perform any index specific tuning at the zap level.segmentConfigis something that's constructed by parsing thescorch.configand persisted in the index_meta.json file.