Skip to content

Add support for variable length tuples in Tuple type_validator #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2020
Merged

Add support for variable length tuples in Tuple type_validator #38

merged 1 commit into from
May 25, 2020

Conversation

@douardda
Copy link
Contributor

@douardda douardda commented May 25, 2020 •
edited
Loading

Closes #37

@erikseulean
Copy link
Contributor

erikseulean commented May 25, 2020

This looks good, thanks for fixing it. I'll accept it when the CI passes.

@douardda
Add support for variable length tuples in Tuple type_validator
ffae54c 
Closes bloomberg#37

Signed-off-by: David Douard <david.douard@sdfa3.org>
@douardda
Copy link
Contributor Author

douardda commented May 25, 2020

Should be ok now.

erikseulean
erikseulean approved these changes May 25, 2020
View reviewed changes
Copy link
Contributor

@erikseulean erikseulean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! ❤️

@erikseulean erikseulean merged commit e533fa1 into bloomberg:master May 25, 2020
@douardda
Copy link
Contributor Author

douardda commented May 25, 2020

Thank you for your very fast review and approval. Any chance to have this published (on pypi) any time soon?

@douardda douardda deleted the issue37 branch May 25, 2020 11:43
@erikseulean
Copy link
Contributor

erikseulean commented May 25, 2020

I just tagged a new release, it should be there in a bit. (v0.0.7)

@erikseulean
Copy link
Contributor

erikseulean commented May 25, 2020

Done:

Installing collected packages: attrs-strict
Successfully installed attrs-strict-0.0.7

keiclone pushed a commit to keiclone/attrs-strict that referenced this pull request May 26, 2020
@douardda @keiclone
Add support for variable length tuples in Tuple type_validator (bloom…
683e1fe 
…berg#38)

Closes bloomberg#37

Signed-off-by: David Douard <david.douard@sdfa3.org>
Signed-off-by: Wilfred Wong <keiclone@users.noreply.github.com>
keiclone pushed a commit to keiclone/attrs-strict that referenced this pull request May 26, 2020
@douardda @keiclone
Add support for variable length tuples in Tuple type_validator (bloom…
9a392ca 
…berg#38)

Closes bloomberg#37

Signed-off-by: David Douard <david.douard@sdfa3.org>
Signed-off-by: Wilfred Wong <keiclone@users.noreply.github.com>
keiclone pushed a commit to keiclone/attrs-strict that referenced this pull request May 26, 2020
@douardda @keiclone
Add support for variable length tuples in Tuple type_validator (bloom…
9e256d2 
…berg#38)

Closes bloomberg#37

Signed-off-by: David Douard <david.douard@sdfa3.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@erikseulean erikseulean erikseulean approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support for Tuple is incorrect/incomplete

2 participants

@douardda @erikseulean