Don't call epoll for non-interactive shells #1751
Closed
+13
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only the interactive shell is supposed to read comments from the input file descriptor. Rework bt_attach_shell() in order to stop calling input_new() / io_new() in a non-interactive case. Fixes bluez#700 Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
There are only two cases, interactive and non-interactive. Make that more obvious by using if-else rather than two if-checks. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
|
BlueZ Testbot Message: This is an automated message and please do not change or delete. Dear submitter, Thanks for submitting the pull request to the BlueZ github repo. If you still want us to review your patch and merge them, please send your For more detail about submitting a patch to the mailing list, Note that this pull request will be closed in the near future. Best regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
btmgmt(and probably other utils) from init script currently fails as shell init will uncoditionally callepoll_ctl()onstdin, which can be/dev/nullin such a case (and/dev/nulldoesn't supportepoll). Reworkbt_shell_attach(), skipping iniput initialization for non-interactive shells.