core: services: helper: main: Control number of worker for scan_ports based on hardware #3478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's guide (collapsed on small PRs)Reviewer's Guidescan_ports now dynamically assigns the ThreadPoolExecutor worker count based on CPU type (Pi3) and the number of ports to optimize CPU usage peaks Class diagram for updated scan_ports worker assignment logicclassDiagram
class Helper {
<<static>> SKIP_PORTS
<<static>> detect_service(port)
}
class CpuType {
PI3
}
class main {
scan_ports()
}
Helper <|-- main
CpuType <|-- main
main : scan_ports() uses get_cpu_type() and len(ports) to set max_workers
main : scan_ports() uses ThreadPoolExecutor(max_workers)
main : scan_ports() submits detect_service(port) for each port
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @joaoantoniocardoso - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `core/services/helper/main.py:435` </location>
<code_context>
+ if get_cpu_type() == CpuType.PI3 or len(ports) == 0:
+ max_workers = 2
+ else:
+ max_workers = len(ports)
+
+ with futures.ThreadPoolExecutor(max_workers=max_workers) as executor:
</code_context>
<issue_to_address>
Setting max_workers to len(ports) may cause excessive thread creation for large port lists.
Consider setting an upper limit for max_workers to prevent resource exhaustion and maintain system stability.
</issue_to_address>
<suggested_fix>
<<<<<<< SEARCH
if get_cpu_type() == CpuType.PI3 or len(ports) == 0:
max_workers = 2
else:
max_workers = len(ports)
with futures.ThreadPoolExecutor(max_workers=max_workers) as executor:
=======
MAX_WORKERS = 8 # Upper limit for thread pool size
if get_cpu_type() == CpuType.PI3 or len(ports) == 0:
max_workers = 2
else:
max_workers = min(len(ports), MAX_WORKERS)
with futures.ThreadPoolExecutor(max_workers=max_workers) as executor:
>>>>>>> REPLACE
</suggested_fix>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+432
to
+437
| if get_cpu_type() == CpuType.PI3 or len(ports) == 0: | ||
| max_workers = 2 | ||
| else: | ||
| max_workers = len(ports) | ||
|
|
||
| with futures.ThreadPoolExecutor(max_workers=max_workers) as executor: |
There was a problem hiding this comment.
suggestion (performance): Setting max_workers to len(ports) may cause excessive thread creation for large port lists.
Consider setting an upper limit for max_workers to prevent resource exhaustion and maintain system stability.
Suggested change
| if get_cpu_type() == CpuType.PI3 or len(ports) == 0: | |
| max_workers = 2 | |
| else: | |
| max_workers = len(ports) | |
| with futures.ThreadPoolExecutor(max_workers=max_workers) as executor: | |
| MAX_WORKERS = 8 # Upper limit for thread pool size | |
| if get_cpu_type() == CpuType.PI3 or len(ports) == 0: | |
| max_workers = 2 | |
| else: | |
| max_workers = min(len(ports), MAX_WORKERS) | |
| with futures.ThreadPoolExecutor(max_workers=max_workers) as executor: |
|
|
||
| # The detect_services run several of requests sequentially, so we are capping the amount of executors to lower the peaks on the CPU usage | ||
| with futures.ThreadPoolExecutor(max_workers=2) as executor: | ||
| if get_cpu_type() == CpuType.PI3 or len(ports) == 0: |
There was a problem hiding this comment.
suggestion (code-quality): Simplify sequence length comparison (simplify-len-comparison)
Suggested change
| if get_cpu_type() == CpuType.PI3 or len(ports) == 0: | |
| if get_cpu_type() == CpuType.PI3 or not ports: |
… based on hardware Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
eeb1913 to
d687b33
Compare
patrickelectric
approved these changes
Aug 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #3362 into 1.4
Summary by Sourcery
Enhancements: