add new test case to commit-proof-fixtures.json #4
+22
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
my first pass at a sync v1.1 inductive firehose implementation passed all the existing test cases, but `goat --verify-mst` still occasionally complained `err: failed to invert op: partial MST, can't determine insertion order`. finally tracked it down to snarfed/arroba@8ef584e, which I minimized (ish) to this test case. hope you don't mind the collections and rkeys, I didn't go to the extra effort of making up test paths with the same set of layers. hopefully they're relatively innocuous without the DID.
Author
|
cc @bnewbold |
Collaborator
|
Thanks! I'll try to dive in and confirm this against our other codebases before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
my first pass at a sync v1.1 inductive firehose implementation passed all the existing test cases, but
goat --verify-mststill occasionally complainederr: failed to invert op: partial MST, can't determine insertion order. finally tracked it down to snarfed/arroba@8ef584e, which I minimized (ish) to this test case.hope you don't mind the collections and rkeys, I didn't go to the extra effort of making up test paths with the same set of layers. hopefully they're relatively innocuous without the DID.