gradle: Use an ArtifactView for jar library elements selection #5702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjhargrave
requested changes
Jun 23, 2023
gradle-plugins/biz.aQute.bnd.gradle/src/main/java/aQute/bnd/gradle/BndPlugin.java
Show resolved
Hide resolved
gradle-plugins/biz.aQute.bnd.gradle/src/main/java/aQute/bnd/gradle/BundleTaskExtension.java
Outdated
Show resolved
Hide resolved
big-guy
suggested changes
Jun 27, 2023
gradle-plugins/biz.aQute.bnd.gradle/src/main/java/aQute/bnd/gradle/BndPlugin.java
Outdated
Show resolved
Hide resolved
gradle-plugins/biz.aQute.bnd.gradle/src/main/java/aQute/bnd/gradle/BndPlugin.java
Show resolved
Hide resolved
|
I am working on improvements to this PR and will soon push them. |
Slightly delayed as there were a number of issue related to updating the build to Gradle 8.1.1 which I first have to resolve. |
1cfabf5 to
9f696b1
Compare
|
I have updated this PR with the additional changes. I tested locally on 8.2-rc-2 successfully but the test case should not hard code the gradle version number. |
9f696b1 to
ae9d5aa
Compare
bjhargrave
approved these changes
Jun 29, 2023
|
@bjhargrave reason you did not merge it? |
Just allowing some time for feedback from @tresat and/or @big-guy. I will merge it later. |
Using an ArtifactView avoids ordering issues when the Jar task is realized prior to the compileClasspath configuration being modified just before resolution. It makes the attributes used to resolve libraries more predictable, and prevents an internal behavior change in Gradle 8.2 from affecting this process. This also avoids modifying attributes on Gradle-created configurations, which should be avoided. Signed-off-by: Tom Tresansky <ttresansky@gradle.com> Signed-off-by: BJ Hargrave <bj@hargrave.dev>
ae9d5aa to
b6966d1
Compare
|
Thanks for addressing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using an ArtifactView avoids ordering issues when the Jar task is
realized prior to the compileClasspath configuration being modified
just before resolution. It makes the attributes used to resolve
libraries more predictable, and prevents an internal behavior change in
Gradle 8.2 from affecting this process.
This also avoids modifying attributes on Gradle-created configurations,
which should be avoided.