add method check to pkgScanner.selectorExpr#24
Conversation
update test to check for methods
Pull Request Test Coverage Report for Build 19779305446Details
💛 - Coveralls |
|
Not sure why this is failing; permissions are set up correctly AFAICT. |
…nt finding the tail element of the type name.
| func seventeen() { | ||
| x := []int{7, 8} | ||
| y := (*[2]int)(x) | ||
| time.Now().GoString() |
There was a problem hiding this comment.
The other code in this file already forces Mingo to compute version 1.17. Adding this call to time.Now().GoString() makes no difference, whether the relevant logic works or doesn't work.
The right way to test this is to put it in its own file (which I've done with bar.go). The presence of time.Now().GoString() should force Mingo to compute version 17 all by itself. I've confirmed that with your fix in place, it does, and without your fix, it doesn't.
bobg
left a comment
There was a problem hiding this comment.
LGTM. Thank you very much!
The problem with Modver being unable to write its comment to this pull request (as part of the GitHub Actions checks) should not block this from merging.
update test to check for methods
fixes #23