CodeQL: remove import linter hack#12645
Merged
Merged
Conversation
bryevdv
commented
Nov 23, 2022
Codecov Report
@@ Coverage Diff @@
## branch-3.1 #12645 +/- ##
===========================================
Coverage 92.16% 92.16%
===========================================
Files 313 313
Lines 19570 19570
===========================================
Hits 18036 18036
Misses 1534 1534 |
mattpap
reviewed
Nov 23, 2022
mattpap
reviewed
Nov 23, 2022
4db610d to
89c48ae
Compare
bryevdv
added a commit
that referenced
this pull request
Dec 6, 2022
* remove API import lint hack in properties.py * remove API import lint hack in plotting/__init__.py * remove API import lint hack in sampledata/__init__.py * remove API import lint hack in document/__init__.py * remove API import lint hack in embed/util.py * remove API import lint hack in top level __init__.py * remove API import lint hack in model/util.py * clean up doc event imports * clean up defaults tests imports * remove non-functional spec.py * review changes
Merged
bryevdv
added a commit
that referenced
this pull request
Dec 7, 2022
* Neutral POV for install instructions (#12603) * Neutral POV for install instructions * Update README.md Co-authored-by: Moritz Schreiber <68053396+mosc9575@users.noreply.github.com> Co-authored-by: Moritz Schreiber <68053396+mosc9575@users.noreply.github.com> * Fix export with fractional CSS lengths (#12613) * Fix layout propagation in nested mixed layouts (#12612) * Replace flake8 with ruff (#12605) * apply fixes * stricter, more fixes * more fixes, check __init__.py better * remove flake8 * add U amd W checks * combine imports * remove spurious # noqa * Remove LGTM (#12620) LGTM service will shut down in a few weeks. https://github.blog/2022-08-15-the-next-step-for-lgtm-com-github-code-scanning/#end-of-november-new-commits-and-pull-requests-are-no-longer-analyzed * Added metadata to glyphs.py, multi_legend.py, multi_scale.py (#12547) * Added metadata to glyphs.py, multi_legend.py, multi_scale.py * Removed trailing whitespaces. * Pared down apis to the most interesting and put it in a single line. * Added the apis in a single line and updated the keywords. * Bv/deprecated apis in tests (#12622) * pydot -> pygraphviz * remove publish_display_data source param * Exlude tmp files from coverage (#12629) * exlude tmp files from coverage * silence linter * Update CodeQL action (#12630) * Update CodeQL action * kick the tires * Fix application of UI element styles in Firefox (#12634) * Add CodeQL config (#12636) * codeql config in proper job * Updates to Docker image building and testing (#12351) * Updates to docker image building * Support all non-firefox tests in docker container * Try ECR upload * Update ECR region and repository * Chromedriver version does not have to match chrome version * Try ECR upload * Try adding custom registry alias * try default registry alias * Try default alias take 2 * specify public registry login * fix registry type config * Try dockerhub * fix typo * Try multiple tags * Option to push or save image * Github action to run tests in docker container * Temporarily force BokehJS-CI to run * Try to get docker testing to run in CI * Run docker in CI using wheel * Use entrypoint script to install from wheel * Final tweaks * Switch to docker testing using image named branch-3.1 * Add test running chromium in Docker without required envvar * Move test-in-docker to separate workflow * Better docker CI names Co-authored-by: Bryan Van de Ven <bryan@bokeh.org> * Disable docker from wheel integration tests (#12639) * Added find_stack_level to util.warnings (#12650) * Added find_stack_level to util.deprecation * Moving deprecation -> warnings * Change to use internal warn * Fix import * Fix lint * Fix failing test * Resolve issues with code quality checks (#12654) * Use type[T] instead of Type[T] where permitted * Pin ruff to last working version (0.0.144) * Compute layout for initially undisplayed components (#12653) * Fix broken bokeh-tree links (#12644) * fix broken bokeh-tree links * fix broken metadata ref * more versioned links * lint * CodeQL: remove import linter hack (#12645) * remove API import lint hack in properties.py * remove API import lint hack in plotting/__init__.py * remove API import lint hack in sampledata/__init__.py * remove API import lint hack in document/__init__.py * remove API import lint hack in embed/util.py * remove API import lint hack in top level __init__.py * remove API import lint hack in model/util.py * clean up doc event imports * clean up defaults tests imports * remove non-functional spec.py * review changes * Add default styles to FILE template (#12656) * Add default styles to FILE template * Don't ignore template files * Skip stocks and surface3d examples * Adapt Bokeh logo for dark theme and add docs badge in README.md (#12659) Co-authored-by: Moritz Schreiber <68053396+mosc9575@users.noreply.github.com> Co-authored-by: Mateusz Paprocki <mattpap@gmail.com> Co-authored-by: Yash Pratapwar <65851650+Yash-Pratapwar@users.noreply.github.com> Co-authored-by: Ian Thomas <ianthomas23@gmail.com> Co-authored-by: Simon Høxbro Hansen <simon.hansen@me.com> Co-authored-by: Pavithra Eswaramoorthy <pavithraes@outlook.com>
Chiemezuo
pushed a commit
to Chiemezuo/bokeh
that referenced
this pull request
Aug 27, 2024
* remove API import lint hack in properties.py * remove API import lint hack in plotting/__init__.py * remove API import lint hack in sampledata/__init__.py * remove API import lint hack in document/__init__.py * remove API import lint hack in embed/util.py * remove API import lint hack in top level __init__.py * remove API import lint hack in model/util.py * clean up doc event imports * clean up defaults tests imports * remove non-functional spec.py * review changes
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CodeQL reports a great number of "Statement has no effect` warnings for our use of this hacky method to suppress linter warnings in the past:
But this hack is not necessary at all if the import is included in
__all__and in fact, our use of the hack only served to prevent contemporary linters from telling us when we failed to to keep__all__up to date, which we had several cases of.This PR removes the import linter hack throughout, fixes up
__all__values that were missing entries, and also removesscript/spec.pywhich was discovered to be non-functional.