Fix resource limit & timeout handling if some assertion in the batch has already failed #994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Sorry for the slow response. Can you add a test for the new behavior? |
Contributor
|
@samuelpilz : If you are still interested in landing this PR, I would like to provide feedback. I am less concerned about a test case and more concerned about the specification of the value being returned by the method you are changing. If you do not wish to pursue this PR further, I would like to close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the root cause of dafny-lang/dafny#5805. In short, this issue arises when boogie runs into a timeout or resource limit while trying to verify subsequent assertions in an assertion batch where one assertion already failed.
In that case, the record
VerificationRunResulthas set theSolverOutcometoInvalidand contains the counterexamples that were found before running into a timeout. The methodVerificationRunResult.ComputePerAssertOutcomesthen assignsValidto all assertions for which no counterexamples have been found because of the timeout, giving issue dafny-lang/dafny#5805.From the standpoint of the method
ComputePerAssertOutcomestwo scenarios are indistinguishable:This PR suggests to fix this by reporting the timeout alongside the found counterexamples.
This change is expected to have some effects for programs built on boogie: I assume that the
VerificationRunResultonly had a nonempty list ofCounterExampleswhen theSolverOutcomeisInvalid. I expect that programs built on boogie would need to adapt to this new possibility and report the verification failure errors accordingly.