Fix: Compile error using woocommerce css#823
Merged
Merged
Conversation
justinkruit
approved these changes
Sep 9, 2024
justinkruit
left a comment
Member
There was a problem hiding this comment.
I was hopeful #829 would work here, but it didn't. Seems like this is the only working solution for now
crftwrk
added a commit
that referenced
this pull request
Apr 28, 2025
Update scssphp 2.0.0 and revert #823
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #801
I solved this now using jQuery to get rid of the SCSS selector. It's not an elegant way, but it works and I think this is just temporary and we can revert this PR when scssphp v2 has fixed this. For this reason, the scss snippet is just commented out.
Go to https://dev.bootscore.me/product/beanie/, add product to the cart and check quantity input and buttons in offcanvas cart. Input and buttons are disabled, because this product has quantity
max="1"attribute.Edit: check #827