Skip to content
This repository was archived by the owner on Feb 13, 2025. It is now read-only.

Add ackTime to incident filters#2014

Merged
kylebrandt merged 2 commits into
masterfrom
ackAgoFilter
Feb 10, 2017
Merged

Add ackTime to incident filters#2014
kylebrandt merged 2 commits into
masterfrom
ackAgoFilter

Conversation

@kylebrandt

Copy link
Copy Markdown
Member

This lets you show incidents that were acknowledged more than X time ago. A useful view to scan for things in ack that maybe need to be resolved.

@kylebrandt kylebrandt requested a review from gbrayut February 10, 2017 17:16
@gbrayut

gbrayut commented Feb 10, 2017

Copy link
Copy Markdown
Contributor

two comments, otherwise LGTM

Comment thread docs/usage.md Outdated
range specified in Grafana. For example, <code>ackTime:<24h</code> shows incidents that were acknowledged more than 24 hours ago.</td>
</tr>
<tr>
<td><code>ackTime:(true|false)</code></td>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this suppose to be ack: instead of ackTime: ?

Comment thread docs/usage.md Outdated
</tr>
<tr>
<td><code>ack:(true|false)</code></td>
<td><code>ackTime:[<|>](1d)</code></td>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like it is not indented correctly

@kylebrandt kylebrandt merged commit 8866155 into master Feb 10, 2017
@kylebrandt kylebrandt deleted the ackAgoFilter branch February 10, 2017 17:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants