Skip to content
This repository was archived by the owner on Feb 13, 2025. It is now read-only.

cmd/bosun fixed tags parameter for silencing button on dashboard#2265

Merged
captncraig merged 1 commit into
bosun-monitor:masterfrom
bookingcom:vpestov/alert-state-tags-fix
Jun 11, 2018
Merged

cmd/bosun fixed tags parameter for silencing button on dashboard#2265
captncraig merged 1 commit into
bosun-monitor:masterfrom
bookingcom:vpestov/alert-state-tags-fix

Conversation

@KozzyKoder

@KozzyKoder KozzyKoder commented Jun 9, 2018

Copy link
Copy Markdown
Contributor

Hello! Fixed small bug.

steps to reproduce:
  1. open bosun dashboard
  2. find any open incident
  3. click on the incident description, an accordeon panel will expand on a dashboard page showing more info about the incident
  4. click on any silencing button directly on dashboard page or just copy a link to the silencing page
expected:

silencing page will understand tags of the alert and fill them in the form

actual result:

when a link to the silencing page is formed we can see undefined instead of tag values, e.g.: https://bosun-host/silence?duration=2h&alert=some_alert&tags=undefined
on the opened silencing page you can see a red highlighted note on top of the page saying 'opentsdb: bad tag: undefined'

Thanks!

@captncraig captncraig merged commit 01e5aa3 into bosun-monitor:master Jun 11, 2018
@KozzyKoder KozzyKoder deleted the vpestov/alert-state-tags-fix branch June 12, 2018 08:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants