Add simulator#135
Merged
Merged
Conversation
added 12 commits
July 19, 2016 22:15
…d_simulator Conflicts: setup.py
mihaic
approved these changes
Oct 12, 2016
mihaic
left a comment
Member
There was a problem hiding this comment.
Looks good. I will merge it after the checks are done.
On a different note, why do you keep closing PRs and opening new ones for the same code? You know that you can simply push new commits to the same branch of your GitHub fork and they will show up in the existing PR, right? Closing a PR makes it harder to follow up on previous comments.
Member
|
Review ready. |
danielsuo
pushed a commit
that referenced
this pull request
Nov 16, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.