-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Upgrade from Chromium 144 to Chromium 145 #32682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
cdesouza-chromium
wants to merge
100
commits into
cr144
Choose a base branch
from
cr145
base: cr144
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+2,284
−2,096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25ec07d to
bea0b59
Compare
b610334 to
748701b
Compare
65af704 to
c26ab62
Compare
749ba23 to
a814a89
Compare
348219d to
ae554e8
Compare
837f5d4 to
39949c3
Compare
0519aa5 to
5cc471f
Compare
ab8a8a0 to
e3529e2
Compare
b909f8a to
2336c11
Compare
dfd4fde to
c646dd2
Compare
e808d8d to
bf5a13e
Compare
bf5a13e to
aaa7b4e
Compare
e80ddde to
a216729
Compare
b678a0d to
cb832ee
Compare
87ffb2a to
87e4c1f
Compare
Chromium changes: https://chromium.googlesource.com/chromium/src/+/ed2e0467b830503b0d97dc31880be4cf2d9e3952 commit ed2e0467b830503b0d97dc31880be4cf2d9e3952 Author: Wenyu Fu <wenyufu@chromium.org> Date: Wed Dec 10 21:16:51 2025 -0800 [Icons] Remove btn_tabstrip_switch_normal Apparently unused. Bug: 467789995, 466238435 Change-Id: I204f20d1a1d3d67260f6ebfbf902a4f91e8d0736 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7248305 Reviewed-by: Joel Tan-Aristy <jtanaristy@google.com> Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/main@{#1557120}
Chromium changes: https://chromium.googlesource.com/chromium/src/+/c4039f85750b4e7b5845545a1131296cd7a07296 commit c4039f85750b4e7b5845545a1131296cd7a07296 Author: Jenna Himawan <jhimawan@google.com> Date: Thu Dec 11 15:25:40 2025 -0800 [Icons] Update Add icon drawable and name Bypass-Check-License: File rename; not a new file Bug: 465844226 Change-Id: I4ae0996076205e52315101082ac3e9b0f15369f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7247464 Reviewed-by: Wenyu Fu <wenyufu@chromium.org> Commit-Queue: Jenna Himawan <jhimawan@google.com> Cr-Commit-Position: refs/heads/main@{#1557733}
Chromium changes: https://chromium.googlesource.com/chromium/src/+/0498a3b2839ee733fac63921d40b3c4f494ea0bc commit 0498a3b2839ee733fac63921d40b3c4f494ea0bc Author: Joel Tan-Aristy <jtanaristy@google.com> Date: Thu Dec 11 15:48:37 2025 -0800 [Icons] Updates volume_up vector drawable Bug: 465844929 Change-Id: I4c4c41a5fa4630a8ba8879ff44d41644c39d8063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7253205 Commit-Queue: Joel Tan-Aristy <jtanaristy@google.com> Reviewed-by: Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/main@{#1557747}
Chromium changes: https://chromium.googlesource.com/chromium/src/+/63fb0f5689e4667f99afc9d2bf903515425aedf6 commit 63fb0f5689e4667f99afc9d2bf903515425aedf6 Author: Sirisha Kavuluru <skavuluru@google.com> Date: Thu Dec 11 16:36:20 2025 -0800 [ToolbarRefactor] Trigger allocateAvailableToolbarWidth when zoom indicator is added to omnibox. allocateAvailableToolbarWidth handles updating all toolbar views based on available layout width and is invoked during Toolbar#onMeasure(). However, location bar URL action container view updates (specifically toggling zoom indicator visibility) does not trigger onMeasure(). Invoking allocateAvailableToolbarWidth() manually for zoom indicator. We might need to do the same for other buttons or pivot to a more scalable solution (eg: onGlobalLayoutChangeListener to listen to child view visibility changes) but landed this as a temporary fix to unblock zoom indicator + toolbar resize exp Bug: 461853892 Change-Id: I22a8113f9a701b826528d7725c13cac78ccfec76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7201190 Auto-Submit: Sirisha Kavuluru <skavuluru@google.com> Reviewed-by: Hitarth Kothari <hitarthkothari@google.com> Reviewed-by: Charles Hager <clhager@google.com> Commit-Queue: Sirisha Kavuluru <skavuluru@google.com> Cr-Commit-Position: refs/heads/main@{#1557771}
Chromium changes: https://chromium.googlesource.com/chromium/src/+/1d7e9c164cf06e791c50e8e32b32ff98aa60e32a commit 1d7e9c164cf06e791c50e8e32b32ff98aa60e32a Author: Wenyu Fu <wenyufu@chromium.org> Date: Wed Dec 10 21:48:59 2025 -0800 [Icons] Update incognito_fill icon incognito_simple -> incognito_fill_24dp. Bug: 466238435 Change-Id: Ibf713feb61631ccf823e0e1b7a6079d1e7ac4c64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7244330 Reviewed-by: Sinan Sahin <sinansahin@google.com> Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/main@{#1557128}
Chromium changes: https://chromium.googlesource.com/chromium/src/+/199c5793cf76c58e931c834ee9bc36437387bb06 commit 199c5793cf76c58e931c834ee9bc36437387bb06 Author: Wenyu Fu <wenyufu@chromium.org> Date: Fri Dec 12 16:41:21 2025 -0800 [Icons] Remove btn_toolbar_reload.png and test_ic_refresh_black_24dp Update `btn_toolbar_reload` as a drawable alias. Since refresh is not automirrored, create `ic_refresh_24dp_rtl.xml` to keep it mirrored in RTL locale. This allows us to remove all the png version of btn_toolbar_reload. Also remove the test only resource that doesn't seem necessary test_ic_refresh_black_24dp.xml. Bug: 465841381 Change-Id: I4d936216bee75a493689f4c3f840178275cadc84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7256663 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by: Joel Tan-Aristy <jtanaristy@google.com> Cr-Commit-Position: refs/heads/main@{#1558360}
Removed unused header includes. Removed unused test parametrization.
ERROR at //brave/browser/ui/views/tabs/brave_tab.cc:27:11: Include not allowed.
^--------------------------------------------------
It is not in any dependency of
//brave/browser/ui:ui
The include file is in the target(s):
//chrome/browser/ui/tabs/alert:tab_alert
which should somehow be reachable.
Chromium change: https://source.chromium.org/chromium/chromium/src/+/f364a8e21e616f7f3b6befe67cec36f14a4d2494 commit f364a8e21e616f7f3b6befe67cec36f14a4d2494 Author: Fumitoshi Ukai <ukai@google.com> Date: Tue Dec 2 21:46:11 2025 -0800 node.py: print stderr/stdout/exit status, attempt 2. previous attempt e24157c11d87344aeeddb2b0f6353bf2947082e3 failed since eslint captures json output in RuntimeError message. instead of parsing RuntimeError message of node.py, introduce RunNodeRaw in node.Run and get (exitcode,stdout,stderr) in JsChecker.RunEsLintCheck. also introduce cwd to pass node.Run, instead of os.chdir before calling node.Run. Cq-Include-Trybots: luci.chromium.try:linux-presubmit,win-presubmit Bug: 461602362
Chromium changes: https://chromium.googlesource.com/chromium/src/+/d0e0d0f95971bb89e7bc0ea29cff39e9439c957b commit d0e0d0f95971bb89e7bc0ea29cff39e9439c957b Author: Sinan Sahin <sinansahin@google.com> Date: Fri Dec 12 08:56:11 2025 -0800 [clank-q4-fixit] Update naming for drag_handle_color and divider_color Bug: 465898786 Change-Id: Ifbd1b75f50f39363e446663ca204912bb75fb19b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7254327 Reviewed-by: Nate Fischer <ntfschr@chromium.org> Reviewed-by: Theresa Sullivan <twellington@chromium.org> Reviewed-by: Wenyu Fu <wenyufu@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/main@{#1558096}
…bservableSupplier Chromium changes: https://chromium.googlesource.com/chromium/src/+/8245d4bdba51505fb715a2106a13a96bc206b860 commit 8245d4bdba51505fb715a2106a13a96bc206b860 Author: Andrew Grieve <agrieve@chromium.org> Date: Fri Dec 12 12:13:49 2025 -0800 Android: Convert ArchivedTabCountSupplier -> SettableNonNullObservableSupplier Bug: 467389696 Change-Id: Ib5d8678cda883235c805fd8c1e925bbfe9cbe18d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7255036 Reviewed-by: Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Owners-Override: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/main@{#1558223}
C'tor versions that take a string have been removed. Chromium change: https://source.chromium.org/chromium/chromium/src/+/729bb5f8da429482dfda293fbaeb12c12e5e3852 commit 729bb5f8da429482dfda293fbaeb12c12e5e3852 Author: Tanmoy Mollik <triploblastic@google.com> Date: Thu Dec 11 03:16:10 2025 -0800 Remove unused methods in PrimaryAccountAccessTokenFetcher The clients that use oauth_consumer_name constructors of this class have been migrated. Bug: 425896213
The registration now causes a CHECK in upstream code because it can only be done from main thread. Need a follow up to fix this, but for now commenting out our code to unblock tests from crashing due to this CHECK. Chromium change: https://source.chromium.org/chromium/chromium/src/+/facfee34d5daf6bbde99f4c5a63f3a6bf229e72b commit facfee34d5daf6bbde99f4c5a63f3a6bf229e72b Author: Patrick Monette <pmonette@chromium.org> Date: Mon Nov 10 19:22:01 2025 -0800 Ensure that NotifyMemoryPressure is called on the main thread Bug: 457269074
Chromium change: https://source.chromium.org/chromium/chromium/src/+/30d29357e1fae019b63af8383017644b951ea4cd commit 30d29357e1fae019b63af8383017644b951ea4cd Author: Joshua Pawlicki <waffles@chromium.org> Date: Thu Dec 4 12:50:33 2025 -0800 chrome/browser/updater: Create a cleaner public interface This creates updater.h and allows all platforms to depend on //chrome/browser/updater. Logic for !enable_updater builds is now centralized in updater_no_updater.cc, and all other headers in the module are made non-public (except to //chrome/test:unit_tests). This is necessary refactoring prior to additional changes to communicate actives to the updater in cross-platform contexts. No behavior change is expected. Bug: 454662418
…ata. Moves initialization of GetComponentExtensionResourceManager data from BraveExtensionsBrowserClientImpl::Init into BraveBrowserProcessImpl::Init. BraveExtensionsBrowserClientImpl::Init is called early in the BrowserProcessImple::Init code and at that point ApplicationLocaleStorage (which is needed by GetComponentExtensionResourceManager) has not been created yet. That now happens at the very end of BrowserProcessImple::Init. So moving the data initialization code to BraveBrowserProcessImple::Init after it calls BrowserProcessImple::Init. Chromium change: https://source.chromium.org/chromium/chromium/src/+/24ba37124af3a5f7b541389fa53c7876290d553f commit 24ba37124af3a5f7b541389fa53c7876290d553f Author: Glenn Hartmann <hartmanng@chromium.org> Date: Thu Dec 11 12:45:21 2025 -0800 Start GlobalFeatures earlier and add more lifecycle hooks. Notable code changes: * `GlobalFeatures` initialization is split into 2 phases, with the first one happening very early in `BrowserProcessImpl::Init()` - before `ProfileManager` is created. The `CreateGlobalFeaturesForTesting()` method is correspondingly split in two. For now, the first phase only initializes `GlobalBrowserCollection`. * `GlobalFeatures` "core features" initialization is also split into 2, since `GlobalBrowserCollection` is a core feature needed in tests, and some tests need to be able to initialize `TestingProfileManager` after `GlobalBrowserCollection` and before the rest of `GlobalFeatures`. * `GlobalFeatures` shutdown is split into 2 phases to mirror the initialization order. The latter shutdown phase only cleans up `GlobalBrowserCollection` for now, and happens very late - in particular, after `ProfileManager` and `ResourceCoordinatorParts` are shut down. * A few unit tests are updated to sandwich the `TestingProfileManager` initialization and shutdown between `GlobalFeatures` init and shutdown phases. This needs to happen in this CL (not a follow-up) because these tests instantiate their own `TestingProfileManager` and also rely on Glic `GlobalFeatures` which interact with `ProfileManager` and `GlobalBrowserCollection`. * New methods `TestingBrowserProcess::SetUpGlobalFeaturesForTesting()` and `TestingBrowserProcess::TearDownGlobalFeaturesForTesting()` are added so test authors (usually) don't need to worry about the specific init and shutdown order of profile manager, global features, and resource coordinator parts. Bug: 467395900
Chromium has done away with `TabDragContextBase`, and it nows expose a lot of the base a delegate. This in particular has not been a source of a lot of problems, however this change itself has caused a lot of inconsitent replacements for `TabDragController`/`TabDragControllerChromiuim` that required fixing. Chromium changes: https://chromium.googlesource.com/chromium/src/+/2e55c6d3915ad62123f98850fe60a6a5c290c3fd commit 2e55c6d3915ad62123f98850fe60a6a5c290c3fd Author: Kaan Alsan <alsan@chromium.org> Date: Mon Dec 15 08:52:11 2025 -0800 Split up TabDragContext interface to remove horizontal-specific methods This is a refactor with no changes in behavior. Some of TabDragContext's methods were only used by DraggingTabsSession, which is solely responsible for updating the horizontal tab strip's layout. These methods are redundant for the upcoming vertical tab strip, and other potential TabDragContext implementors. This CL splits up TabDragContext's interface to add a new TabDragPositioningDelegate interface which is only used by the horizontal tab strip. Pieces of the TabDragController's logic are also gated on the existence of this delegate; these pieces of logic are not necessary for the core tab dragging mechanism to work. Longer term, this new interface should be removed altogether and all positioning logic should be implemented by the horizontal tab strip through the TabDragDelegate. Bug: 439963720 Change-Id: Ide1dc44e90fe6bab6556e65e50c2a6b399a13077 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7253392 Commit-Queue: Kaan Alsan <alsan@chromium.org> Reviewed-by: David Pennington <dpenning@chromium.org> Reviewed-by: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/main@{#1558766}
This change has affected the override we have, being `BraveTab`, as well as every place where instantiation of `Tab` was taking place. `TabStrip::AddTabsAt` in particular also changed, as it now takes a struct with bundled values as an argument. Chromium changes: https://chromium.googlesource.com/chromium/src/+/9b973dd63748270306a8f6c0e166dfe00d6b0033 commit 9b973dd63748270306a8f6c0e166dfe00d6b0033 Author: Eshwar Stalin <estalin@chromium.org> Date: Mon Dec 15 10:04:29 2025 -0800 Removing dependency of Tab view from TabUnderlineView In order to be able to reuse TabUnderlineView across Horizontal and Vertical Tabs, removing the dependency of Tab view. Additionally, also removed the WeakPtr TabInterface member from the TabRendererData. Change-Id: I117866f0e7df0d248af4e85ac3d8b89e94ddccd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7259434 Commit-Queue: Eshwar Stalin <estalin@chromium.org> Reviewed-by: David Pennington <dpenning@chromium.org> Cr-Commit-Position: refs/heads/main@{#1558818}
This function was always returning true, so its removal is inconsequential. Chromium changes: https://chromium.googlesource.com/chromium/src/+/ace5239e77770408af21d0600dd21405e0019025 commit ace5239e77770408af21d0600dd21405e0019025 Author: Alison Gale <agale@chromium.org> Date: Mon Dec 15 11:17:24 2025 -0800 [SxS] Clean up split view feature functions and params This CL removes the trivial feature state functions and params not related to drag and drop Bug: 454347097 Change-Id: I3cc9fdca9a861d516337dd6ff803d7986bc7b2b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7261285 Reviewed-by: David Pennington <dpenning@chromium.org> Commit-Queue: Alison Gale <agale@chromium.org> Cr-Commit-Position: refs/heads/main@{#1558864}
This requires to wrap the return value into strings for this map type used in tests. Chromium changes: https://chromium.googlesource.com/chromium/src/+/f32bb69091d7eef27f5d4c8d695650380d154182 commit f32bb69091d7eef27f5d4c8d695650380d154182 Author: Matt Menke <mmenke@chromium.org> Date: Tue Dec 16 06:40:51 2025 -0800 Rework [TryTo]GetHttpReasonPhrase() API. Previously, GetHttpReasonPhrase() had a NOTREACHED() on unrecognized values (that was specced to return nullptr in non-debug builds). TryToGetHttpReasonPhrase() behaved the same way, but without the NOTREACHED(). Most callers use GetHttpReasonPhrase() without validating the input. At least two of them are encountering null deref crashes (web_app::LogDownloadedIconsErrors() and ash::nearby::NearbyHttpStatus::ToString()), though not often. One or two are checking for nulls despite calling GetHttpReasonPhrase(), which was never really correct, but which didn't used to CHECK() in non-debug builds, though with NOTREACHED() becoming a CHECK(), that will change soon. This CL refactors GetHttpReasonPhrase() to always return a value, even in the unknown case, to avoid CHECK() failures. It also introduces an overload that takes an int instead of an HttpStatusCode, as most callers were just casting an int to an HttpStatusCode, anyways. This CL makes the test-only CustomHttpResponse::SendResponse() return the (new) standard "Unknown Status Code" instead of "Custom" in the case of unknown status codes, for simplicity. Bug: 465823612 Change-Id: Iaec596b0392fd8fa091655086657a2ee541d6742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7232577 Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Slobodan Pejic <slobodan@chromium.org> Reviewed-by: Andrew Rayskiy <greengrape@google.com> Reviewed-by: Benoit Lize <lizeb@chromium.org> Commit-Queue: mmenke <mmenke@chromium.org> Reviewed-by: Pavol Marko <pmarko@chromium.org> Reviewed-by: Daniel Classon <dclasson@google.com> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/main@{#1559297}
This was part of a fix that was submitted by us to them close to a year ago, and only now has landed. Chromium changes: https://chromium.googlesource.com/chromium/src/+/1e3d336850cfe3edf478cddf7f677f5d71b5d939 commit 1e3d336850cfe3edf478cddf7f677f5d71b5d939 Author: Florian Leimgruber <fleimgruber@google.com> Date: Tue Dec 16 02:52:13 2025 -0800 Upgrade libaddressinput The autoroller failed (crrev.com/c/7263112), since some of the APIs changed. This CL fixes the breakages. Bug: None Change-Id: Ic6dd8babdba39a93c5ae3a8ccf93df39236238bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7264646 Commit-Queue: Florian Leimgruber <fleimgruber@google.com> Reviewed-by: Dominic Battre <battre@chromium.org> Cr-Commit-Position: refs/heads/main@{#1559226}
Chromium changes: https://chromium.googlesource.com/chromium/src/+/1566063d73f4c207dda97bc7ccab52291794faec commit 1566063d73f4c207dda97bc7ccab52291794faec Author: Christian Dullweber <dullweber@chromium.org> Date: Mon Dec 15 07:33:23 2025 -0800 Legion: Remove legion from Android build The code is currently only used on Desktop and should not be included in Android builds Change-Id: Ibd1388163c872aa51ca263e37dc491d3e158a2ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7261300 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Auto-Submit: Christian Dullweber <dullweber@chromium.org> Reviewed-by: Oleh Lamzin <lamzin@google.com> Commit-Queue: Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/main@{#1558722}
…servableSupplier Chromium changes: https://chromium.googlesource.com/chromium/src/+/78262fcabdb7ea6154698ce2d8de3be38685d7d1 commit 78262fcabdb7ea6154698ce2d8de3be38685d7d1 Author: Andrew Grieve <agrieve@chromium.org> Date: Mon Dec 15 13:20:12 2025 -0800 Android: Convert TabStripTopControlLayer -> SettableNonNullObservableSupplier Bug: 467389696 Change-Id: I4fa5212f316941730391acc9682256bf08ce0190 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7262594 Reviewed-by: Henrique Nakashima <hnakashima@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/main@{#1558950}
1c61b3a to
8d7ac78
Compare
Collaborator
|
Warning You have got a presubmit warning. Please address it if possible. Items: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI/run-audit-deps
Check for known npm/cargo vulnerabilities (audit_deps)
CI/run-network-audit
Run network-audit
CI/run-upstream-tests
Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux)
CI/storybook-url
Deploy storybook and provide a unique URL for each build
feature/web3/wallet/core
feature/web3/wallet
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#51212