Return CONFLICT for inserting items with duplicate client tags#62
Merged
Conversation
fba880b to
00d3195
Compare
This is a temporary approach, will be reverted really soon.
00d3195 to
8167969
Compare
darkdh
approved these changes
Feb 24, 2021
AlexeyBarabash
approved these changes
Feb 24, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have seen cases that some clients kept getting TRANSIENT_ERROR when they trying to insert new items with duplicate client tags and cannot recover from it, and clients kept trying the same commits which cannot be accepted by the server due to duplicate client tags.
We are having a hard time to reproduce it, in theory we think return CONFLICT in this case makes more sense, the change is in the first commit of this PR.
The second commit is to limit the scope to specific clients first, and will be reverted pretty soon.