feat: add the ability to format more than one project at a time.#84
Merged
Conversation
Signed-off-by: jaudiger <jeremy.audiger@ioterop.com>
kylewlacy
approved these changes
Jul 12, 2024
Member
kylewlacy
left a comment
There was a problem hiding this comment.
LGTM
I did find one thing that could be improved: if you run brioche fmt --check -p project1 -p project2 and both projects have formatting issues, then only the files for one of the projects will get printed
But I also don't feel that this is a blocker, I'm fine merging this as-is and handling that as a future issue or follow-up
Contributor
Author
|
Thank you, I'll do that in a follow-up. I always prefer to reduce the scope of my PRs. To reduce the review burden, the regression's scope, etc. At the end there are more PRs opened, but that's my trade-off |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the ability to format more than one project at a time by authorizing the usage of multiple
-parguments.Part of #75