fix-auto-download #3443
Merged
fix-auto-download #3443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iptions - Updated the `write_file` action to include detailed documentation on supported file formats (.txt, .md, .json, .jsonl, .csv, .pdf) and conversion process for PDF files. - Refined the `text` field description in `DoneAction` to clarify the expected format for user summaries. - Improved the `success` field description in `StructuredOutputAction` to specify its meaning more clearly. These changes aim to enhance clarity and usability for developers interacting with the API.
Agent Task Evaluation Results: 2/2 (100%)View detailed results
Check the evaluate-tasks job for detailed task execution logs. |
Collaborator
Author
Evaluation ResultsCommit: 📊 Summary
Automated evaluation by browser-use |
Collaborator
Author
Evaluation ResultsCommit: 📊 Summary
Automated evaluation by browser-use |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Collaborator
Author
Evaluation ResultsCommit: 📊 Summary
Automated evaluation by browser-use |
…loadsWatchdog with global network response handling - Introduced `get_target_id_from_session_id` method in `BrowserSession` to facilitate lookup of target IDs from CDP session IDs. - Updated `DownloadsWatchdog` to register a global network response callback, improving detection of downloadable content. - Enhanced error handling and logging for network response events to ensure better tracking of downloads and potential issues. These changes aim to improve the reliability and functionality of session management and download monitoring in the browser automation framework.
Collaborator
Author
Evaluation ResultsCommit: 📊 Summary
Automated evaluation by browser-use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto-generated PR for branch: fix-auto-download
Note
Adds CDP Network-based monitoring to detect and auto-download PDFs/attachments across targets, with deduping and background downloads; exposes session→target lookup and tweaks tool action descriptions.
browser_use/browser/watchdogs/downloads_watchdog.py):Network.enableand a globalNetwork.responseReceivedcallback.Content-Disposition: attachmentresponses (including iframes/JS-triggered) and auto-download in background usingdownload_file_from_url(JSfetch).browser_use/browser/session.py):get_target_id_from_session_id(session_id)to map CDP session IDs totarget_idfor event routing.write_fileaction description updated to list supported formats and PDF behavior (browser_use/tools/service.py).DoneActionandStructuredOutputActionfield descriptions (browser_use/tools/views.py).Written by Cursor Bugbot for commit 00b11e1. This will update automatically on new commits. Configure here.