better descripiton for extract #3468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Agent Task Evaluation Results: 2/2 (100%)View detailed results
Check the evaluate-tasks job for detailed task execution logs. |
Collaborator
Author
Contributor
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="browser_use/tools/service.py">
<violation number="1" location="browser_use/tools/service.py:588">
`params` is still a plain dict when this action runs, so accessing `params.query` raises an AttributeError and breaks the extract action.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
| ): | ||
| # Constants | ||
| MAX_CHAR_LIMIT = 30000 | ||
| query = params.query |
Contributor
There was a problem hiding this comment.
params is still a plain dict when this action runs, so accessing params.query raises an AttributeError and breaks the extract action.
Prompt for AI agents
Address the following comment on browser_use/tools/service.py at line 588:
<comment>`params` is still a plain dict when this action runs, so accessing `params.query` raises an AttributeError and breaks the extract action.</comment>
<file context>
@@ -577,15 +578,16 @@ async def close(params: CloseTabAction, browser_session: BrowserSession):
):
# Constants
MAX_CHAR_LIMIT = 30000
+ query = params.query
+ extract_links = params.extract_links
+ start_from_char = params.start_from_char
</file context>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto-generated PR for: better descripiton for extract
Note
Replace extract’s loose params with a new ExtractAction model and adjust handling/error text accordingly.
browser_use/tools/service.py):params: ExtractAction; readquery,extract_links,start_from_charfromparams.start_from_charbounds.browser_use/tools/views.py):ExtractActionwithquery,extract_links,start_from_char.Written by Cursor Bugbot for commit 1383604. This will update automatically on new commits. Configure here.