fix: prevent KeyError crash in OpenAI reasoning models #3540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix KeyError that occurs when using OpenAI reasoning models (o1, o3, etc.) with temperature=None or frequency_penalty=None. The code was using 'del' to remove keys that may not exist in model_params dictionary. Changed to use .pop() with default value for safe key removal. Fixes crash scenario: - ChatOpenAI(model='o1-mini', temperature=None) -> KeyError Changes: - Replace 'del model_params[key]' with 'model_params.pop(key, None)' - Ensures parameters are safely removed even if not present in dict
|
|
Contributor
Author
|
@MagMueller @gregpr07 PLease review and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix KeyError that occurs when using OpenAI reasoning models (o1, o3, etc.) with temperature=None or frequency_penalty=None.
The code was using 'del' to remove keys that may not exist in model_params dictionary. Changed to use .pop() with default value for safe key removal.
Fixes crash scenario:
Changes:
Summary by cubic
Prevent KeyError crashes when using OpenAI reasoning models by safely removing temperature and frequency_penalty from model_params with .pop(). Calls like ChatOpenAI(model='o1-mini', temperature=None) no longer crash.
Written for commit 0263f05. Summary will update automatically on new commits.