Implement demo mode for in-browser logging #3554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
1 issue found across 9 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="browser_use/browser/demo_mode.py">
<violation number="1" location="browser_use/browser/demo_mode.py:690">
Rendering the log message with innerHTML means any markup in the payload will run in the page context. Please use a safe text assignment or sanitize the payload before inserting it.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
…security by preventing HTML injection.
Contributor
Author
|
When filming demos, having to screen between browser and terminal requires more work. Having the logs directly in the panel can be a good thing. |
3c4586b to
1c85a8a
Compare
Collaborator
|
super cool! |
Collaborator
|
Happy to merge this |
Collaborator
|
is there a way to make it consistent across navigation? |
Collaborator
|
|
Collaborator
|
maybe you could even find a way how we could make this so nice that people want to have this as default |
Collaborator
|
maybe similar to the gif version |
Collaborator
|
or e.g. we just show the action as a small overlay in the lower right corner |
Contributor
Author
|
yes, i will try to work on it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Adds a demo mode that injects a side panel into the browser to stream live agent logs and state. This lets you follow actions, thoughts, errors, and results without checking the console.
New Features
Migration
Written for commit c29e358. Summary will update automatically on new commits.
Note
Adds an optional demo mode that injects a browser side panel to stream live agent/code-agent logs, with session-scoped DOM exclusion and logging hooks across the stack.
DemoModehelper and injected JS panel streaming logs viawindowevents; persisted per-page, toggleable floating button.BrowserProfile.demo_modeflag (default false);BrowserSession.demo_modelazy helper;send_demo_mode_log()API; auto-injected on start; warns if headless.AgentandCodeAgentacceptdemo_mode; broadcast step start/completion, actions (and params), LLM responses/thinking/evaluations, memory/next goal, errors, and final/partial results to the panel.session_idtoDOMTreeSerializer; filter elements marked with session-specificdata-browser-use-exclude-<session_id>(fallback to legacy attr); propagation throughDomService,Page.get_element_by_prompt.examples/demo_mode_example.pyshowcasingAgent(..., demo_mode=True).Written by Cursor Bugbot for commit c29e358. This will update automatically on new commits. Configure here.