Rebasing region label work from PR 1853#2703
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2703 +/- ##
==========================================
+ Coverage 82.68% 82.72% +0.04%
==========================================
Files 59 59
Lines 4718 4735 +17
==========================================
+ Hits 3901 3917 +16
- Misses 817 818 +1
Continue to review full report at Codecov.
|
Contributor
|
@dunderpate Ideally we should document those new options in the reference. And if this could be greenlighted by @kt3k that would be awesome 👍 |
Closed
Contributor
Author
|
@panthony, thanks for the review. I'll take a stab at updating the reference documentation. |
Contributor
Author
|
Right on, ready for a review of the documentation when you have time @panthony. Thanks! |
Contributor
|
@dunderpate Looks good! Thanks! |
Contributor
Author
|
Right on, thanks @panthony! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @panthony, here's an updated patch for PR #1853.
The tests failed due to something seemingly unrelated (legend padding), and the same failure was also occurring on master. Apart from that, everything else seemed to work fine. Feel free to let me know if there's anything amiss and I'll be happy to fix it.
Thanks @panthony!