Skip to content

Updated to default to "all" view on view all button click #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
droberts-ctrlo wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Updated to default to "all" view on view all button click #584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b12e50
Updated to default to "all" view on view all button click
droberts-ctrlo Oct 17, 2025
9f9ef82
Removed unneccessary Devel::StackTrace
droberts-ctrlo Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/GADS.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2675,11 +2675,12 @@ prefix '/:layout_name' => sub {
{
$params->{curval_layout_id} = query_parameters->get('curval_layout_id');
$params->{curval_record_id} = query_parameters->get('curval_record_id');
$params->{hide_view_menu} = 1;
}

my $records = GADS::Records->new(%params);

$records->view($view);
$records->view(query_parameters->get('curval_record_id') ? undef : $view);
$records->rows($rows);
$records->page($page);
$records->sort(session 'sort');
Expand Down
2 changes: 1 addition & 1 deletion lib/GADS/API.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1092,7 +1092,7 @@ sub _get_records {
my $sheetname = param 'sheet';
my $user = logged_in_user;
my $layout = var('instances')->layout_by_shortname($sheetname); # borks on not found
my $view = current_view($user, $layout);
my $view = query_parameters->get('curval_record_id') ? undef : current_view($user, $layout);

# Allow parameters to be passed by URL query or in the body. Flatten into
# one parameters object
Expand Down
6 changes: 6 additions & 0 deletions views/navigation/records_top_bar.tt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,15 @@
<div class="content-block__navigation-left">
<div class="list list--horizontal">
<ul class="list__items">
[% IF hide_view_menu %]
<li class="list__item text-primary font-weight-bold">
<p>Curval View</p>
</li>
[% ELSE %]
<li class="list__item ">
[% INCLUDE navigation/dropdown_select_view.tt %]
</li>
[% END %]

<li class="list__item ">
[%
Expand Down