Skip to content

Conversation

@rhavran
Copy link
Contributor

@rhavran rhavran commented Jan 22, 2020

No description provided.

@rhavran rhavran requested a review from lsuski January 22, 2020 22:13
@rhavran
Copy link
Contributor Author

rhavran commented Jan 22, 2020

Hello @lsuski, could you please check the commit, does this change make sense to you?
Thanks!

@lsuski
Copy link
Contributor

lsuski commented Jan 24, 2020

I'll look deeper into it in next week. It looks simple

@lsuski lsuski merged commit 857b2a1 into cucumber:master Jan 30, 2020
@aslakhellesoy
Copy link
Contributor

Hi @rhavran,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

@rhavran
Copy link
Contributor Author

rhavran commented Jan 30, 2020

Hi @aslakhellesoy,
Thank you for having me in the Cucumber committers team🙂💚

@rhavran rhavran deleted the 4.4.0 branch January 31, 2020 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants