Skip to content

Conversation

@alerque
Copy link
Contributor

@alerque alerque commented May 12, 2025

PR #379 has crosswired paths and the latest release does not build an install completions as expected.

@jacobmealey
Copy link
Contributor

Hi, thanks for fixing this. I'm not sure how this Happened.

@alerque
Copy link
Contributor Author

alerque commented May 12, 2025

For one of these you must have messed about locally and had obsolete files from your development process in the way. In other words it was never tested after a git clean or similar. For the other if it was ever tested you must have tested it as root without a destdir and never noticed what it did.

@jacobmealey
Copy link
Contributor

Yeah, that makes sense. I'll be sure to test from a clean state in the future, especially with the Makefiles. Sorry if this has caused any headache. Again thanks for fixing this.

@bagder bagder merged commit 0ce73c1 into curl:master May 13, 2025
10 checks passed
@bagder
Copy link
Member

bagder commented May 13, 2025

Thanks!

@alerque alerque deleted the fix-zsh-completions branch May 13, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants