Skip to content

Fix exponential cone for MOSEK#862

Merged
akshayka merged 1 commit into
masterfrom
mosek-fix
Nov 6, 2019
Merged

Fix exponential cone for MOSEK#862
akshayka merged 1 commit into
masterfrom
mosek-fix

Conversation

@akshayka
Copy link
Copy Markdown
Collaborator

@akshayka akshayka commented Nov 6, 2019

Checked out from rileyjmurray's PR (#860)

Checked out from rileyjmurray's PR (#860)
@akshayka akshayka requested a review from rileyjmurray November 6, 2019 00:17
@akshayka
Copy link
Copy Markdown
Collaborator Author

akshayka commented Nov 6, 2019

@rileyjmurray, I copied this change from your PR. If it looks good to you, I'll merge it in.

@rileyjmurray
Copy link
Copy Markdown
Collaborator

It's fine to merge as-is, but you might also want to specifically try the logistic regression example mentioned in the other thread. MOSEK is now passing its mosek_conif.py unittests (and it wasn't before), but I haven't run the logistic regression example. I did try to run the logistic regression example, but it's a Jupyter notebook and I can't get jupyter to work at the moment.

@rileyjmurray
Copy link
Copy Markdown
Collaborator

Actually I just copied the ipython notebook into a python script, and that did run correctly on my laptop. So yes, I would say this is good to merge.

@akshayka
Copy link
Copy Markdown
Collaborator Author

akshayka commented Nov 6, 2019

Thanks!

@akshayka akshayka merged commit 4b52c91 into master Nov 6, 2019
@akshayka akshayka deleted the mosek-fix branch November 20, 2019 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants