Conversation
Fixes a bug in DQCP analysis in analyzing monotone real functions; DQCP analysis previously did not check whether the argument of a scalar function was also scalar. This bug caused DQCP analysis to be too permissive, incorrectly labeling things as DQCP and causing the reduction to fail in surprising ways. As an extension, this change adds the vector atoms cp.max and cp.min to the DQCP atom library, letting users take the max or min of quasiconvex or quasiconcave expressions. Previously, only the elementwise cp.maximum and cp.minimum atoms were allowed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug in DQCP analysis in analyzing monotone real functions; DQCP
analysis previously did not check whether the argument of a scalar function
was also scalar. This bug caused DQCP analysis to be too permissive, incorrectly
labeling things as DQCP and causing the reduction to fail in surprising ways.
As an extension, this change adds the vector atoms cp.max and cp.min to the
DQCP atom library, letting users take the max or min of quasiconvex or
quasiconcave expressions. Previously, only the elementwise cp.maximum and
cp.minimum atoms were allowed.
Fixes #904