fix: Add INTRA_DIVISION_RECORD tiebreaker rule
#666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the `League.standings_weekly()` did not recognize this rule and would throw an error `Unkown tiebreaker_method: Must be either 'TOTAL_POINTS_SCORED' or 'H2H_RECORD'`
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #666 +/- ##
==========================================
- Coverage 71.19% 71.13% -0.07%
==========================================
Files 62 62
Lines 2368 2370 +2
==========================================
Hits 1686 1686
- Misses 682 684 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DesiPilla
added a commit
to DesiPilla/espn-api-v3
that referenced
this pull request
Sep 25, 2025
`espn-api` does not support the tiebreaker `INTRA_DIVISION_RECORD`. A [PR](cwendt94/espn-api#666) has been made, but until it is merged and the version is released, this hotfix will have to suffice.
Contributor
Author
|
@cwendt94 This PR is ready for merging. |
cwendt94
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
League.standings_weekly()did not recognize this rule and would throw an errorUnkown tiebreaker_method: Must be either 'TOTAL_POINTS_SCORED' or 'H2H_RECORD'