Skip to content

scope stack doesn't allways display or doesn't display proper scope or doesn't handle scopes correctly in certain instances #63

Open

Description

@BiscuitCookies

Example for displaying incorrectly:
if a decision is a targeted_decision towards a state the FROM scope should be a state, but in the tooltip says FROM is a country scope. It does handle it as as state scope though.

image
image
image

Example for not handling:
in on_actions a on action like on_unit_leader_promote_from_ranks_veteran will allow any trigger or effect in it's effect block. Like it allows a trigger that requires a country scope and a trigger that requires a state scope at the same time on the same level.

image
image
image

I've been trying to work around by editing the hoi4 cwt rules but haven't had any luck with getting the on_actions to work

Activity

  1. changed the title [-]scope stack doesn't allways display or doesn't display proper scope or doesn't handle scopes in certain instances[/-] [+]scope stack doesn't allways display or doesn't display proper scope or doesn't handle scopes correctly in certain instances[/+] on Feb 8, 2024
  2. BiscuitCookies commented on Feb 8, 2024

    @BiscuitCookies
    Author

    I've managed to get on_action working with scopes but it required removing the subtypes. In general it seems like scopes and subtypes don't always work nicely. EDIT: with subtypes also works but have to move the replace_scope to the effect = part in the subtype, but that still causes the wrong scope to be displayed in the tooltip.

    Another issue I found is specifically with FROM.FROM not giving the correct scope.
    image
    image

    On a related note the autocomplete for hoi4 suggest prevprev or fromfrom instead of prev.prev and from.from.

  3. Pelmen323 commented on Mar 24, 2024

    @Pelmen323
    Member

    A note for a future myself - to revert Kaiserreich/cwtools-hoi4-config@ede26ae once this issue is fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions