Fix: app gets into invalidate state after copy #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Give more flexibility to user by 1. Allowing the use of environment variable AR_CP_SERVER_URL 2. Extract serverUrl from Server.tsx into app.json
The fix proposed uses a single variable "appState" of type AppState to maintain the app's state. AppState type can be one of: Init - start up of app CopyReady - app is ready to copy PasteReady - app is ready to paste Busy - app is waiting for results State variable "pressed" and "pasting" have both been removed. The fix *significantly changes the user experience* where it's tap to copy and then tap to paste.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users reported bugs #41, #45 where they were able to copy but not
paste. This is basically a user experience issue where the user didn't
know they had to hold the finger until the copy operation is complete.
However, once a user takes a picture and lift her finger while
the cut command has not completed from the server, the app gets into a state
where it's not recoverable.
The fix proposed uses a single variable "appState" of type AppState to maintain
the app's state. AppState type can be one of:
State variable "pressed" and "pasting" have both been removed.
The fix significantly changes the user experience where it's tap to copy
and then tap to paste.
If we'd like to go back to the hold-then-release UX, we'd need to
discuss on how the UX can be more intuitive.
Fixes #41, #45