Skip to content

enhance: throw runtime error on absent ffmpeg binary#3850

Merged
Wendong-Fan merged 3 commits into
masterfrom
enhance/return-error-on-run
Feb 18, 2026
Merged

enhance: throw runtime error on absent ffmpeg binary#3850
Wendong-Fan merged 3 commits into
masterfrom
enhance/return-error-on-run

Conversation

@a7m-1st

@a7m-1st a7m-1st commented Feb 17, 2026

Copy link
Copy Markdown
Collaborator

Related Issue

Closes #3849

Description

throws the below on runtime if not present, rather than an obscure error along the stack.

RuntimeError: FFmpeg is not installed or not found in your system PATH. Please install FFmpeg:
  - Windows: 'winget install ffmpeg' or download from https://ffmpeg.org/download.html
  - macOS: 'brew install ffmpeg'
  - Linux: 'sudo apt install ffmpeg' or 'sudo yum install ffmpeg'
After installation, restart your terminal for the changes to take effect.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Checklist

  • I have read and agree to the AI-Generated Code Policy (required)
  • I have linked this PR to an issue (required)
  • I have checked if any dependencies need to be added or updated in pyproject.toml and run uv lock
  • I have updated the tests accordingly (required for a bug fix or a new feature)
  • I have updated the documentation if needed
  • I have added examples if this is a new feature

If you are unsure about any of these, don't hesitate to ask. We are here to help!

@a7m-1st a7m-1st self-assigned this Feb 17, 2026
@a7m-1st a7m-1st marked this pull request as ready for review February 17, 2026 20:23
@coderabbitai

coderabbitai Bot commented Feb 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch enhance/return-error-on-run

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the Review Required PR need to be reviewed label Feb 17, 2026
waleedalzarooni
waleedalzarooni approved these changes Feb 18, 2026
View reviewed changes

@waleedalzarooni waleedalzarooni left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wendong-Fan

Wendong-Fan commented Feb 18, 2026

Copy link
Copy Markdown
Member

there's some pre-commit issue to fix @a7m-1st @waleedalzarooni

@Wendong-Fan Wendong-Fan merged commit 7584cda into master Feb 18, 2026
12 of 13 checks passed
@Wendong-Fan Wendong-Fan deleted the enhance/return-error-on-run branch February 18, 2026 07:59
@a7m-1st

a7m-1st commented Feb 18, 2026

Copy link
Copy Markdown
Collaborator Author

Oh it should been applied automatically. Thanks for noticing @Wendong-Fan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@waleedalzarooni waleedalzarooni waleedalzarooni approved these changes

@Wendong-Fan Wendong-Fan Wendong-Fan approved these changes

@4pmtong 4pmtong Awaiting requested review from 4pmtong

@fengju0213 fengju0213 Awaiting requested review from fengju0213

Assignees

@a7m-1st a7m-1st

Labels

Review Required PR need to be reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] VideoDownloaderToolkit fails silently on ffmpeg absent

3 participants

@a7m-1st @Wendong-Fan @waleedalzarooni