Skip to content

feat: add support for v2 format #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 20, 2025
Merged

feat: add support for v2 format #197

merged 2 commits into from
Jun 20, 2025
+89 −2

Conversation

@letFunny
Copy link
Collaborator

@letFunny letFunny commented Jan 24, 2025

  • Have you signed the CLA?

@zhijie-yang @letFunny
Add support for v2 format (#25)
e6a1e40 
* feat: add support for format v2

---------

Co-authored-by: Alberto Carretero <alberto.carretero@canonical.com>
@letFunny letFunny changed the title Add support for v2 format feat: add support for v2 format Jan 24, 2025
@letFunny letFunny added the Simple Nice for a quick look on a minute or two label Jan 24, 2025
@letFunny letFunny requested a review from niemeyer January 24, 2025 15:52
niemeyer
niemeyer approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@niemeyer niemeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks all good, thank you.

Do we want to do anything else before we merge the PR and brand the code as v2?
Any other pending transitions?

@letFunny
Copy link
Collaborator Author

letFunny commented Jan 27, 2025

@niemeyer The idea is to introduce the first version with v2 after we the conflict resolution. We can put this PR on hold and merge both on them at the same time or we can merge this now. I prefer the former just in case we want to do a point release in the meantime.

@niemeyer
Copy link
Contributor

niemeyer commented Jan 27, 2025

@letFunny Sounds good. I'm marking this issue as done on my end for the time being. Please ping me when it's time.

@niemeyer niemeyer added the Reviewed Supposedly ready for tuning or merging label Jan 27, 2025
@letFunny letFunny removed the Reviewed Supposedly ready for tuning or merging label May 2, 2025
@letFunny
Copy link
Collaborator Author

letFunny commented May 2, 2025

Discussed with Cris offline and this is ready for review.

@github-actions
Copy link

github-actions bot commented May 2, 2025

Command Mean [s] Min [s] Max [s] Relative
BASE 8.434 ± 0.020 8.394 8.463 1.00
HEAD 8.461 ± 0.024 8.421 8.492 1.00 ± 0.00

@cjdcordeiro cjdcordeiro added the Priority Look at me first label May 22, 2025
niemeyer
niemeyer approved these changes Jun 16, 2025
View reviewed changes
Copy link
Contributor

@niemeyer niemeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems mechanically fine, but let's please check status with Chris as it's been a while since we discussed the v2 updates.

cjdcordeiro
cjdcordeiro approved these changes Jun 20, 2025
View reviewed changes
Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The ubuntu-25.04 chisel-release has been opened with v1, and ubuntu-2*.04 (LTS) chisel-releases are currently using the v2-archives field for the Pro archives (also under the v1 format).

After merging this PR:

  • I'll release Chisel v1.2.0
  • open chisel-release ubuntu-25.10 with v2
  • v2-archives is already removed from v2 in this PR, so we're good there

@niemeyer niemeyer merged commit 3985d62 into canonical:main Jun 20, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@niemeyer niemeyer niemeyer approved these changes

@cjdcordeiro cjdcordeiro cjdcordeiro approved these changes

Assignees

No one assigned

Labels

Priority Look at me first Simple Nice for a quick look on a minute or two

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@letFunny @niemeyer @cjdcordeiro @zhijie-yang