Misc improvements#15681
Merged
Merged
Conversation
Adding the `/etc/inittab` was a workaround added in 2015 but it seems to not be required anymore. Also, the workaround used a leading `/` which annoyed `tar` that needed to strip it to avoid path traversal attacks. ``` $ tar tvf c50b454b13f4f017b067e047e08ec53a19eb3ec9f7e4310ff9cb89a0b4a96127.tar.xz ... drw-r--r-- 0/0 0 1969-12-31 19:00 rootfs/tmp/ drw-r--r-- 0/0 0 1969-12-31 19:00 templates/ -rw-r--r-- 0/0 236 1969-12-31 19:00 templates/template.tpl -rw-r--r-- 0/0 380 1969-12-31 19:00 metadata.yaml tar: Removing leading `/' from member names -rw-r--r-- 0/0 1 1969-12-31 19:00 /rootfs/etc/inittab ``` Signed-off-by: Simon Deziel <simon.deziel@canonical.com> test/deps/import-busybox: use HTTPS link Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
…egments Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
1cb230b to
48a21c6
Compare
tomponline
approved these changes
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.