Skip to content

Update linux_dmabuf_v1 to version 5.#4001

Merged
AlanGriffiths merged 14 commits intocanonical:mainfrom
robert-ancell:linux-dmabuf-v5
Jul 1, 2025
Merged

Update linux_dmabuf_v1 to version 5.#4001
AlanGriffiths merged 14 commits intocanonical:mainfrom
robert-ancell:linux-dmabuf-v5

Conversation

@robert-ancell
Copy link
Copy Markdown
Contributor

No description provided.

@robert-ancell robert-ancell requested a review from a team as a code owner June 10, 2025 05:06
We don't need to pass it through from KMS, the EGL version will be correct.
Copy link
Copy Markdown
Contributor

@RAOF RAOF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a libmirplatform ABI break, so we need to do that dance.

Otherwise looks good (and works, too). Can we get a WLCS test? 😉

Comment thread src/platform/graphics/linux_dmabuf.cpp Outdated
Comment thread src/platform/graphics/linux_dmabuf.cpp
@robert-ancell robert-ancell requested a review from RAOF June 19, 2025 02:18
@robert-ancell
Copy link
Copy Markdown
Contributor Author

I've updated the ABI (please check if correct) and taken a task to look at WLCS next pulse.

@RAOF
Copy link
Copy Markdown
Contributor

RAOF commented Jun 26, 2025

Sorry for not getting to this today! I got waylaid while trying to test it by #4047

Copy link
Copy Markdown
Contributor

@RAOF RAOF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out I did manage to get to this today!

Testing indicates that it's working fine. I've re-triggered the tests, as they seem to be unrelated (and possibly fixed by Saviq's recent wlcs change?)

@robert-ancell robert-ancell added this pull request to the merge queue Jun 26, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 26, 2025
@robert-ancell robert-ancell enabled auto-merge June 26, 2025 23:46
@robert-ancell robert-ancell added this pull request to the merge queue Jun 27, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 27, 2025
@RAOF RAOF added this pull request to the merge queue Jun 27, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 27, 2025
@robert-ancell robert-ancell added this pull request to the merge queue Jun 30, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 30, 2025
Copy link
Copy Markdown
Contributor

@AlanGriffiths AlanGriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we safe dropping linux_dmabuf_unstable_v1? Won't we encounter clients that expect the old protocol extension?

Comment thread src/platform/symbols.map
Comment thread src/platform/graphics/linux_dmabuf.cpp
@robert-ancell
Copy link
Copy Markdown
Contributor Author

Are we safe dropping linux_dmabuf_unstable_v1? Won't we encounter clients that expect the old protocol extension?

The interface name hasn't changed - it is still "zwp_linux_dmabuf_v1". The protocol name dropped the unstable suffix, but this only affects the .xml file name. So all existing clients will continue to work.

@robert-ancell
Copy link
Copy Markdown
Contributor Author

This was blocked by TICS stating that the addition to src/platform/graphics/egl_extensions.cpp not having code coverage.

Comment thread src/platform/symbols.map
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're breaking ABI, so we can consolidate the symbols into a single 2.22 stanza.

(Sorry, didn't think of that last time)

@AlanGriffiths AlanGriffiths added this pull request to the merge queue Jul 1, 2025
Merged via the queue into canonical:main with commit eb5f039 Jul 1, 2025
29 of 30 checks passed
@robert-ancell robert-ancell deleted the linux-dmabuf-v5 branch July 8, 2025 21:00
@Saviq Saviq mentioned this pull request Aug 12, 2025
@Saviq Saviq mentioned this pull request Aug 26, 2025
github-merge-queue bot pushed a commit that referenced this pull request Aug 27, 2025
# Breaking changes:
  - Consolidation of EDID parsing
- `User-..` and `DisplayConfigurationOutput::edid` replaced with
`::display_info`
    - `mir::graphics::Edid` removed
    - `miroil::Edid::Descriptor` removed
  - Nvidia 565+ breaks EGLStream support (#4147)
Use `--platform-display-libs mir:atomic-kms --platform-rendering-libs
mir:gbm-kms` to use our (unstable) Nvidia-on-GBM support.
    We'll follow up with a point release to make this the default.

# ABI summary:
  - miral ABI unchanged at 7
  - mircommon ABI unchanged at 11
  - mircore ABI unchanged at 2
  - miroil ABI bumped to 8
  - mirplatform ABI bumped to 32
  - mirserver ABI bumped to 65
  - mirwayland ABI unchanged at 5
  - mirplatformgraphics ABI unchanged at 23
  - mirinputplatform ABI unchanged at 10

# Enhancements:
- static_config_display: add property-based display config support
(#3872)
  - Implement Simulated Secondary Click (#3873)
  - DRM: Explicit synchorisation support (#3717)
  - live configuration facilities (#3995)
  - Atomic KMS: enable bypass (#3595)
  - fix: move minimized windows to the back of the Z stack (#4000)
  - Implement the 'overlay_cursor' flag for WlrScreencopy (#4013)
- Support Nvidia through the atomic-kms/gbm platforms (#3979, #4060,
#4070)
  - Implement hover click (#3928)
  - server: add `--vt-switching` option (#4033)
  - Improve support for bespoke Wayland extensions (#4018)
  - Update linux_dmabuf_v1 to version 5. (#4001)
  - Implement bounce keys  (#3934)
  - Implement slow keys (#3945)
  - Implement magnifier accessibility feature (#3976)
  - feature: implement sticky keys accessibility feature (#4076)
  - Integrate some Rust code into the Mir build (#4022)
- (#4078) package mir-platform-graphics-stub and mir-platform-input-stub
(#4080)
- graphics: introduce EDID parsing in `DisplayConfigurationOutput`
(#4099)
  - Add live_config support to miral::Keymap (#4088)
  - Add tracking keymap from locale1 (#4111)

# Bugs fixed:
  - Don't raise the parent of windows sent to the back (#4008)
- Update wl_output::geometry to include the correct transformation
(#4062)
- `BasicScreenshooter` does not take the output transformation into
account (#4086)
  - Screenshots wrong when display rotated (again) (#3909)
  - Docking kgx left/right in miriway is misplaced (#4023)

# Documentation:
  - HACKING.md: Add some intructions for MESA debugging (#3992)
  - doc: add Debugging section to CI docs (#4034)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants