chore: fix failed unit test #697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benhoyt
approved these changes
Sep 10, 2025
flotter
pushed a commit
to flotter/pebble
that referenced
this pull request
Sep 23, 2025
Fix the newly added unit test `TestExecChangeReady`. Since we merged the other PR that refactors the logging, the regex needs to be updated. Also, revert a change in `api_tasks.go`; it is supposed to be an internal error instead of not found. In the refactor PR, we should only change the format of the error, not the type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the newly added unit test
TestExecChangeReady.Since we merged the other PR that refactors the logging, the regex needs to be updated. Also, revert a change in
api_tasks.go; it is supposed to be an internal error instead of not found. In the refactor PR, we should only change the format of the error, not the type.