Skip to content

Conversation

@flotter
Copy link
Contributor

@flotter flotter commented Sep 30, 2025

FAIL: manager_test.go:297: ManagerSuite.TestFailuresBelowThreshold

manager_test.go:332:
    c.Assert(lastTaskLog(s.overlord.State(), check.ChangeID), Matches, `.* INFO succeeded after \d+ failure`)
... value string = "2025-09-30T12:25:21Z INFO succeeded after 5 failures"
... regex string = ".* INFO succeeded after \\d+ failure"

Tweak the test to handle the plural version of the error string.

Copy link
Contributor

@benhoyt benhoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@benhoyt benhoyt changed the title chore(test): fix pluralise incompatible check test(checkstate): fix pluralise incompatible check Sep 30, 2025
@benhoyt benhoyt merged commit 96a8a5a into canonical:master Sep 30, 2025
20 checks passed
@benhoyt benhoyt deleted the feature/test-checks-failure branch September 30, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants