chore(daemon): improve UserState test coverage #716
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command method for serving end-points
is also responsible for looking up named identities if one exists. Otherwise, it checks if a peer credential UID is available, even if no named local username is associated with it.
Following the addition of basic auth and certificate based identities, exactly what is passed to the response function
specifically,
UserState, is more complicated to picture.Add tests to cover all the identity types, to capture what we expect in each identity case.
The tests also highlight that components, such as
notices, only supporting UID (and not yet names identities) cannot work with all named identity types.