Skip to content

Update flask-framework extension #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Mar 18, 2024
Merged

Update flask-framework extension #499

merged 32 commits into from
Mar 18, 2024

Conversation

@weiiwang01
Copy link
Contributor

@weiiwang01 weiiwang01 commented Mar 5, 2024 •
edited
Loading

Some refactoring was performed, and some improvements were made over the flask-framework extension.

Changes include:

  • Update the extension part name prefix from flask/ to flask-framework/.
  • Install statsd-exporter along with the Gunicorn server.
  • Install ca-certificates in the ROCK image by default.
  • Disable the WSGI path check when services.flask.command is overridden.
  • Improve the quality of generated parts.
  • Have you signed the CLA?

weiiwang01 and others added 20 commits September 28, 2023 10:25
@weiiwang01 @tigarmo
feat: new flask extension (canonical#317)
e2d7756 
Co-authored-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Co-authored-by: Tiago Nobrega <tiago.nobrega@canonical.com>
@weiiwang01
feat: provide a default prime in the flask extension (canonical#374)
d47ea4d
@weiiwang01
feat(extensions): add a profile option to the rockcraft init command (c…
badac0e 
…anonical#379)
@tigarmo
chore(deps): update craft-providers to 1.19.2
53615ea 
The current version has two bugs (the "looping timer" one and the "not
collecting error logs" one) that are blocking for many users. Ideally we
should merge main into this branch, this is a stopgap before we can
allocate time for it.
@tigarmo
Merge remote-tracking branch 'origin/main' into merge-main
a81da55
@tigarmo
chore: manual updates to align with origin/main
2b711d6 
These are related to the change in base notation (ubuntu@ instead of
ubuntu:) and the changes due to general craft-application-flow.
chore: merge origin/main
b8e0fa5
chore: merge origin/main
a24f8ea
@tigarmo
fix(docs): remove duplicate how-to entries
3a3a536
@tigarmo
Merge pull request canonical#454 from canonical/12f-merge
6b13298 
This brings in the latest changes from `main` into the 12f branch.
@gregory-schiano
Merge branch 'main' into feature/12f
8280e32
@gregory-schiano
Fix schema validation
db8e5a6
@gregory-schiano
Fix typo
71decbc
@gregory-schiano
Template requires input variables
fd07e52
@gregory-schiano
Fix lint
8b84449
@gregory-schiano
Fix lint
786e174
@gregory-schiano
Merge commit '17d6a0447f71b4f32657500e876903fa8be9f74c' into feature/12f
3bfeef2
chore: merge main into feature/12f
fc7ea6b
@weiiwang01
Update flask-framework extension
ff3bf7d
@weiiwang01
Merge remote-tracking branch 'upstream/main' into update-flask-framework
939a092
@weiiwang01
Copy link
Contributor Author

weiiwang01 commented Mar 5, 2024

@sergiusens @tigarmo here's the pull request to bring only the latest flask-framework to the main branch.

tigarmo
tigarmo approved these changes Mar 15, 2024
View reviewed changes
Copy link
Collaborator

@tigarmo tigarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! To whoever is also reviewing this, this is the merge of the feature/12f branch "officially" into main (with some minor updates)

cmatsuoka
cmatsuoka reviewed Mar 15, 2024
View reviewed changes
cmatsuoka
cmatsuoka reviewed Mar 15, 2024
View reviewed changes
cmatsuoka
cmatsuoka reviewed Mar 15, 2024
View reviewed changes
@cmatsuoka cmatsuoka self-requested a review March 15, 2024 15:26
lengau
lengau reviewed Mar 15, 2024
View reviewed changes
@sergiusens
Copy link

sergiusens commented Mar 15, 2024

we have linter errors, are those expected?

@weiiwang01 @lengau
Apply suggestions from code review
48433ec 
Co-authored-by: Alex Lowe <alex.lowe@canonical.com>
@weiiwang01
Copy link
Contributor Author

weiiwang01 commented Mar 18, 2024

we have linter errors, are those expected?

The issue was caused by an external website (https://yaml.org/) going down, which has been resolved now.

@tigarmo
Copy link
Collaborator

tigarmo commented Mar 18, 2024

Will merge this as soon as I can merge this hotfix (we prefer to merge hotfix branches as soon as possible)

@tigarmo tigarmo merged commit a6d85d0 into canonical:main Mar 18, 2024
@weiiwang01 weiiwang01 deleted the update-flask-framework branch March 19, 2024 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tigarmo tigarmo tigarmo approved these changes

@lengau lengau lengau left review comments

@cmatsuoka cmatsuoka cmatsuoka approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@weiiwang01 @sergiusens @tigarmo @cmatsuoka @lengau @gregory-schiano