Skip to content

feat: use versioned form of doc urls #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 12, 2024
Merged

feat: use versioned form of doc urls #634

merged 2 commits into from
Jul 12, 2024

Conversation

@tigarmo
Copy link
Collaborator

@tigarmo tigarmo commented Jul 11, 2024 •
edited
Loading

This updates the links used for errors, but also for init templates.

Example with a fake version 9.9.9:

❯ rockcraft init --profile=flask-framework
Created 'rockcraft.yaml'.
Go to https://documentation.ubuntu.com/rockcraft/en/9.9.9/reference/extensions/flask-framework to read more about the 'flask-framework' profile.

❯ cat rockcraft.yaml 
name: rockcraft
# see https://documentation.ubuntu.com/rockcraft/en/9.9.9/explanation/bases/
# for more information about bases and using 'bare' bases for chiselled rocks
base: ubuntu@22.04 # the base environment for this Flask application
...

@tigarmo tigarmo force-pushed the work/CRAFT-3073-versioned-doc-urls branch 3 times, most recently from 838df86 to 3e2b7c9 Compare July 11, 2024 21:11
@tigarmo tigarmo requested a review from a team July 11, 2024 21:15
@tigarmo
Copy link
Collaborator Author

tigarmo commented Jul 11, 2024

keeping it as draft because of the dev craft-app

tigarmo added 2 commits July 12, 2024 13:00
@tigarmo
build(deps): bump craft-application to 3.2.0
6b9ab03
@tigarmo
feat: use versioned form of doc urls
4936aea 
This updates the links used for errors, but also for init templates.
@tigarmo tigarmo force-pushed the work/CRAFT-3073-versioned-doc-urls branch from 3e2b7c9 to 4936aea Compare July 12, 2024 16:02
@tigarmo tigarmo marked this pull request as ready for review July 12, 2024 16:07
lengau
lengau approved these changes Jul 12, 2024
View reviewed changes
Copy link
Collaborator

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tigarmo tigarmo requested a review from a team July 12, 2024 17:02
@tigarmo tigarmo merged commit f0d7570 into main Jul 12, 2024
@tigarmo tigarmo deleted the work/CRAFT-3073-versioned-doc-urls branch July 12, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lengau lengau lengau approved these changes

@mr-cal mr-cal mr-cal approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tigarmo @lengau @mr-cal