docs: add a guide for adding internal users to rocks #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

tigarmo merged 20 commits into main from ROCKS-1251/docs/how-to-add-internal-user-to-a-rock

Aug 16, 2024

Contributor

linostar commented Jul 29, 2024 •

edited

Loading

Have you signed the CLA?

Adding a new how-to guide that explains how to add an internal user or group (aside from _daemon_) inside a rock.

The method selected for that is by adding the user/group in override-build instead of doing it in overlay. This is because overlay won't work on rocks with bare bases.

github-actions bot added the documentation label

linostar force-pushed the ROCKS-1251/docs/how-to-add-internal-user-to-a-rock branch 8 times, most recently from 30e9af2 to e96bdc1 Compare

July 29, 2024 15:25

linostar marked this pull request as ready for review

July 29, 2024 15:26

linostar requested review from a team and cjdcordeiro

July 29, 2024 15:42


          docs: add a guide for adding internal users to rocks

6ca4d64

linostar force-pushed the ROCKS-1251/docs/how-to-add-internal-user-to-a-rock branch from e96bdc1 to 6ca4d64 Compare

July 30, 2024 06:44

mr-cal approved these changes

View reviewed changes

mr-cal requested a review from a team

July 30, 2024 14:07

cjdcordeiro requested changes

View reviewed changes

docs/how-to/rocks/add-internal-user-in-rocks.rst Outdated Show resolved Hide resolved

lengau requested changes

View reviewed changes

docs/how-to/rocks/add-internal-user-in-rocks.rst Outdated Show resolved Hide resolved

docs/how-to/rocks/add-internal-user-in-rocks.rst Outdated Show resolved Hide resolved

docs/how-to/rocks/add-internal-user-in-rocks.rst Outdated Show resolved Hide resolved

docs/how-to/rocks/add-internal-user-in-rocks.rst Outdated Show resolved Hide resolved

docs/how-to/rocks/add-internal-user-in-rocks.rst Outdated Show resolved Hide resolved

docs/how-to/rocks/add-internal-user-in-rocks.rst Outdated Show resolved Hide resolved

docs/how-to/rocks/add-internal-user-in-rocks.rst Outdated Show resolved Hide resolved


          apply Alex review changes

168acd3

linostar requested a review from lengau

August 1, 2024 07:44

tigarmo requested changes

View reviewed changes

docs/how-to/code/internal-user/rockcraft.yaml Show resolved Hide resolved

docs/how-to/rocks/add-internal-user-in-rocks.rst Outdated Show resolved Hide resolved

docs/how-to/rocks/add-internal-user-in-rocks.rst Outdated Show resolved Hide resolved

docs/how-to/rocks/add-internal-user-in-rocks.rst Outdated Show resolved Hide resolved

docs/how-to/code/internal-user/rockcraft.yaml Outdated Show resolved Hide resolved

docs/how-to/rocks/add-internal-user-in-rocks.rst Outdated Show resolved Hide resolved

docs/how-to/rocks/add-internal-user-in-rocks.rst Outdated Show resolved Hide resolved

Anas Husseini added 2 commits

August 1, 2024 16:50


          address tiago review comments

cb0b90a


          remove the requirement of passwd_bins slice

275340e

linostar requested review from cjdcordeiro and tigarmo

August 1, 2024 13:58


          fix linting issues

8377d49

tigarmo approved these changes

View reviewed changes

Collaborator

tigarmo left a comment

thanks!

cjdcordeiro requested changes

View reviewed changes

docs/how-to/code/internal-user/task.yaml Outdated Show resolved Hide resolved

docs/how-to/rocks/add-internal-user-in-rocks.rst Outdated Show resolved Hide resolved

docs/how-to/rocks/add-internal-user-in-rocks.rst Outdated Show resolved Hide resolved

docs/how-to/rocks/add-internal-user-in-rocks.rst Outdated Show resolved Hide resolved

docs/how-to/rocks/add-internal-user-in-rocks.rst Outdated Show resolved Hide resolved

docs/how-to/rocks/add-internal-user-in-rocks.rst Outdated Show resolved Hide resolved

docs/how-to/code/internal-user/rockcraft.yaml Outdated Show resolved Hide resolved

docs/how-to/rocks/add-internal-user-in-rocks.rst Outdated Show resolved Hide resolved

docs/how-to/code/internal-user/rockcraft.yaml Outdated Show resolved Hide resolved

docs/how-to/code/internal-user/rockcraft.yaml Outdated Show resolved Hide resolved


          address some review changes

7a627ba

linostar force-pushed the ROCKS-1251/docs/how-to-add-internal-user-to-a-rock branch from 837afc5 to 7a627ba Compare

August 6, 2024 12:42

linostar force-pushed the ROCKS-1251/docs/how-to-add-internal-user-to-a-rock branch 3 times, most recently from a8999bd to 971d831 Compare

August 12, 2024 14:21


          fix link

71ed977

linostar force-pushed the ROCKS-1251/docs/how-to-add-internal-user-to-a-rock branch from 971d831 to 71ed977 Compare

August 12, 2024 17:19

linostar requested a review from medubelko

August 12, 2024 17:29


          fix the spread test

c872e70

linostar force-pushed the ROCKS-1251/docs/how-to-add-internal-user-to-a-rock branch from fa4bfc5 to c872e70 Compare

August 12, 2024 18:20

Anas Husseini added 2 commits

August 13, 2024 05:22


          remove obsolete part

27c15a0


          Merge branch 'main' into ROCKS-1251/docs/how-to-add-internal-user-to-…

e8d6986

…a-rock

linostar requested a review from cjdcordeiro

August 13, 2024 02:30

linostar force-pushed the ROCKS-1251/docs/how-to-add-internal-user-to-a-rock branch 2 times, most recently from 5529868 to b924d63 Compare

August 13, 2024 09:28


          switch to node service

d7525a9

linostar force-pushed the ROCKS-1251/docs/how-to-add-internal-user-to-a-rock branch from b924d63 to d7525a9 Compare

August 13, 2024 10:33

cjdcordeiro requested changes

View reviewed changes

docs/how-to/code/internal-user/rockcraft.yaml Outdated Show resolved Hide resolved

docs/how-to/code/internal-user/rockcraft.yaml Show resolved Hide resolved

docs/how-to/code/internal-user/task.yaml Outdated Show resolved Hide resolved


          newline addition

a8ccebf

linostar force-pushed the ROCKS-1251/docs/how-to-add-internal-user-to-a-rock branch 3 times, most recently from 3512e23 to d0bc571 Compare

August 14, 2024 03:08


          switch to a simple python http server example

linostar force-pushed the ROCKS-1251/docs/how-to-add-internal-user-to-a-rock branch from d0bc571 to 1475399 Compare

August 14, 2024 03:14

linostar requested a review from cjdcordeiro

August 14, 2024 03:23

cjdcordeiro approved these changes

View reviewed changes

Contributor

cjdcordeiro left a comment

much cleaner. thanks


          [REVIEW] Add a clean copy of the sample rockcraft YAML

5ae1325

Including the working rockcraft.yaml as-is displays the code breakpoints on the page, which is no good.

medubelko approved these changes

View reviewed changes

Contributor

medubelko left a comment •

edited

Loading

Pushed a small change to remove the breakpoint comments in rockcraft.yaml from the rendered page. LGTM.

Contributor Author

linostar commented Aug 16, 2024

@tigarmo This should be ready for merging.


          Merge branch 'main' into ROCKS-1251/docs/how-to-add-internal-user-to-…

f5fff2d

…a-rock

tigarmo merged commit 86bc240 into main

tigarmo deleted the ROCKS-1251/docs/how-to-add-internal-user-to-a-rock branch

August 16, 2024 20:11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet