-
Notifications
You must be signed in to change notification settings - Fork 60
merge feature/pydantic-2 #672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run bump-pydantic and perform the fixes that let the unit tests run (and fail).
This clears the Pydantic warnings - many tests still error out.
It's missing because we exclude the 'overlays.rst' doc from craft-parts, preferring instead our own.
It's not only no longer needed but newer versions use ruamel YAML, which is currently not compatible with our yaml-dumping-needs: the fields are always sorted by default, we would need to write a new string representer, etc.
This comes from the fix in part validation in craft-application
This gives us the config dict for free and keeps the models consistent.
There is a redirect from the previous one to this one but it breaks the link checker.
mr-cal
approved these changes
Aug 14, 2024
lengau
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has all the commits from the pydantic 2 migration, including the final dependencies. All code has already been reviewed, and the PR itself can be rebase-merged.