Skip to content

Conversation

@tigarmo
Copy link
Collaborator

@tigarmo tigarmo commented Aug 14, 2024

This PR has all the commits from the pydantic 2 migration, including the final dependencies. All code has already been reviewed, and the PR itself can be rebase-merged.

tigarmo added 15 commits August 14, 2024 11:51
Run bump-pydantic and perform the fixes that let the unit tests run (and fail).
This clears the Pydantic warnings - many tests still error out.
It's missing because we exclude the 'overlays.rst' doc from craft-parts,
preferring instead our own.
It's not only no longer needed but newer versions use ruamel YAML, which is
currently not compatible with our yaml-dumping-needs: the fields are always
sorted by default, we would need to write a new string representer, etc.
This comes from the fix in part validation in craft-application
This gives us the config dict for free and keeps the models consistent.
There is a redirect from the previous one to this one but it breaks the
link checker.
@mr-cal mr-cal requested a review from a team August 14, 2024 16:07
@lengau lengau merged commit 034ca5c into main Aug 14, 2024
@lengau lengau deleted the feature/pydantic-2 branch August 14, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants