Skip to content

Conversation

@lengau
Copy link
Collaborator

@lengau lengau commented Aug 16, 2024

  • Have you signed the CLA?

@lengau lengau changed the title Style/ruff style(lint): fix ruff 0.6 linting errors Aug 16, 2024
@lengau lengau force-pushed the style/ruff branch 2 times, most recently from 3f99d04 to dab8d9c Compare August 16, 2024 21:00
@lengau lengau marked this pull request as ready for review August 16, 2024 21:05
@lengau lengau requested review from a team, cjdcordeiro, linostar and tigarmo August 16, 2024 21:05
Copy link
Contributor

@linostar linostar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lengau lengau marked this pull request as draft August 19, 2024 17:25
@lengau
Copy link
Collaborator Author

lengau commented Aug 19, 2024

Moving back to draft so I can:

  1. Add ruff in CI
  2. Remove pylint
  3. Ensure all the pylint linters are enabled in ruff

@lengau lengau force-pushed the style/ruff branch 2 times, most recently from 2b5712f to 227f667 Compare August 19, 2024 19:01
@lengau lengau requested review from cmatsuoka and linostar August 19, 2024 20:09
@lengau lengau marked this pull request as ready for review August 19, 2024 20:09
@lengau lengau changed the title style(lint): fix ruff 0.6 linting errors style(lint): replace pylint with ruff Aug 19, 2024
Copy link
Collaborator

@tigarmo tigarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is great ;)

@lengau lengau requested a review from tigarmo August 23, 2024 17:14
@lengau lengau mentioned this pull request Aug 23, 2024
1 task
@tigarmo
Copy link
Collaborator

tigarmo commented Aug 27, 2024

@lengau just to confirm: are you adding the requirements*txt updates here?

@lengau
Copy link
Collaborator Author

lengau commented Aug 27, 2024

@tigarmo I was planning on doing #678 once this is merged, but if you'd prefer I can put the requirements file here.

@tigarmo
Copy link
Collaborator

tigarmo commented Aug 27, 2024 via email

Copy link
Collaborator

@tigarmo tigarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a thousand blessings upon you and your house

@tigarmo tigarmo merged commit b7d7059 into main Aug 27, 2024
@tigarmo tigarmo deleted the style/ruff branch August 27, 2024 22:22
@lengau lengau mentioned this pull request Aug 28, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants