Skip to content

feat: JLink plugin #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 55 commits into from
Closed

feat: JLink plugin #688

wants to merge 55 commits into from

Conversation

@vpa1977
Copy link
Contributor

@vpa1977 vpa1977 commented Aug 29, 2024 •
edited
Loading

  • Have you signed the CLA?

This PR adds jlink plugin that allows to generate Java runtime tailored for the Java application.
When ran without supplying jar file property it will search the staging area for any jars and generate an image for them.
If no jar files are found, then java.base image will be generated.

This PR includes unit and integration tests.
The plugin documentation is split into separate PR: #689

Sample ROCK using plugin: https://github.com/canonical/openjdk-rocks/tree/prototype/demos/java-runtime

@vpa1977
Copy link
Contributor Author

vpa1977 commented Sep 9, 2024

Added PR for the linkcheck linter failure: #700

@vpa1977
Copy link
Contributor Author

vpa1977 commented Sep 9, 2024 •
edited
Loading

This is probably worth having a plugin-jlink spread test like the plugin-python ones.

Thanks!!! I have added one.

@vpa1977 vpa1977 requested a review from lengau September 9, 2024 06:24
@lengau
Copy link
Collaborator

lengau commented Sep 21, 2024

I discussed this with my team this week, and the conclusion was that the way we should do this is as an option for the base Java plugin.

So the default behaviour would be the current behaviour (which I think is to not stage a JRE?), but the jlink options here would be changed to <plugin>-jlink-<option>, and if any of them are set, it would use jlink to stage the JRE. Do you think that's reasonable/feasible?

lengau
lengau reviewed Sep 21, 2024
View reviewed changes
@vpa1977
Copy link
Contributor Author

vpa1977 commented Sep 22, 2024 •
edited
Loading

I discussed this with my team this week, and the conclusion was that the way we should do this is as an option for the base Java plugin.

So the default behaviour would be the current behaviour (which I think is to not stage a JRE?), but the jlink options here would be changed to <plugin>-jlink-<option>, and if any of them are set, it would use jlink to stage the JRE. Do you think that's reasonable/feasible?

Hmm, so we will have to enumerate plugin properties in java plugin and retrieve ones with jlink key in it?

Also we need ability to decouple build and stage Java.
Example is test libraries requiring higher version then the release jar.
In this case we will have to stage Java runtime in a separate part.

@vpa1977 vpa1977 mentioned this pull request Oct 13, 2024
Closed
1 task
@vpa1977 vpa1977 requested a review from lengau October 13, 2024 19:40
@cjdcordeiro cjdcordeiro requested review from linostar and removed request for gregory-schiano November 15, 2024 11:02
@vpa1977
Copy link
Contributor Author

vpa1977 commented Nov 19, 2024

Closing PR - we will implement this functionality in the base java plugin

@vpa1977 vpa1977 closed this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lengau lengau Awaiting requested review from lengau

@linostar linostar Awaiting requested review from linostar

1 more reviewer

@gregory-schiano gregory-schiano gregory-schiano left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vpa1977 @jdkandersson @lengau @gregory-schiano