Skip to content

Conversation

@jdkandersson
Copy link
Contributor

  • Have you signed the CLA?

Implements the findings from the UX research

@jdkandersson
Copy link
Contributor Author

@tigarmo could you take a look at the read the docs issue please? It seems that the build isn't working again. It also seems there is a broken link which is why the linting is failing


``rockcraft pack`` will create a new image with the updated code even if you
don't change the version. It is recommended to change the version whenever
you make changes to the application in the image.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumping the version number in the tutorial is good because it demos how software releases integrate with rockcraft, and demos the chisel feature, but I think some may interpret this as "whenever changes are made during development" and not just when software releases are made.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeh I was thinking about the same when I was writing that sentence. How else would you word it?

Copy link
Contributor

@clay-lake clay-lake Aug 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps something like this

    ``rockcraft pack`` will overwrite any existing image with the same filename. 
     Updating the version field in the `rockcraft.yaml` will automatically update the 
     filename upon packing, preventing conflicts with prior image versions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, that makes it sound like the motivation is around keeping files around, do you think it is more related to releasing?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would argue in the tutorial its more about keeping the images so we can compare the chiseled and unchiseled images, but in the context of software development I would only expect the software version to be bumped occasionally.

Copy link
Contributor

@erinecon erinecon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@tigarmo tigarmo requested a review from lengau September 6, 2024 11:44
@tigarmo tigarmo requested a review from a team September 9, 2024 14:24
@tigarmo tigarmo merged commit 1c80d92 into canonical:main Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants