-
Notifications
You must be signed in to change notification settings - Fork 60
Implement ux research for flask-framework tutorial #690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@tigarmo could you take a look at the read the docs issue please? It seems that the build isn't working again. It also seems there is a broken link which is why the linting is failing |
|
|
||
| ``rockcraft pack`` will create a new image with the updated code even if you | ||
| don't change the version. It is recommended to change the version whenever | ||
| you make changes to the application in the image. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bumping the version number in the tutorial is good because it demos how software releases integrate with rockcraft, and demos the chisel feature, but I think some may interpret this as "whenever changes are made during development" and not just when software releases are made.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeh I was thinking about the same when I was writing that sentence. How else would you word it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps something like this
``rockcraft pack`` will overwrite any existing image with the same filename.
Updating the version field in the `rockcraft.yaml` will automatically update the
filename upon packing, preventing conflicts with prior image versions.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, that makes it sound like the motivation is around keeping files around, do you think it is more related to releasing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would argue in the tutorial its more about keeping the images so we can compare the chiseled and unchiseled images, but in the context of software development I would only expect the software version to be bumped occasionally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
Implements the findings from the UX research