Language changes, pop-up warning, clarify instructions #709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update the language to be more aligned with a tutorial, i.e., a learning experience we're going on together - Added a note about a pop-up window that may appear when the user installs python-venv - Clarified instructions in the "Update Django application" section to replace the contents of the time_app/views.py and django_hello_world/urls.py files. If the user inserts the contents without replacing the previous text, this leads to an Internal Service Error when the user sends a request to the /time/ endpoint.
jdkandersson
approved these changes
Sep 19, 2024
jdkandersson
approved these changes
Sep 20, 2024
|
Perhaps ping @tigarmo to get this pr reviewed 🙂 |
tigarmo
reviewed
Sep 20, 2024
lengau
reviewed
Sep 20, 2024
Co-authored-by: Alex Lowe <alex.lowe@canonical.com>
jdkandersson
approved these changes
Sep 24, 2024
lengau
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the language to be more aligned with a tutorial, i.e., a learning experience we're going on together
Added a note about a pop-up window that may appear when the user installs python-venvClarified instructions in the "Update Django application" section to replace the contents of the time_app/views.py and django_hello_world/urls.py files. If the user inserts the contents without replacing the previous text, this leads to an Internal Service Error when the user sends a request to the /time/ endpoint.
Have you signed the CLA?