Skip to content

Conversation

@tigarmo
Copy link
Collaborator

@tigarmo tigarmo commented Sep 26, 2024

The plugin has the same behavior and restrictions as the Python plugin with regards to base-dependent behavior, symlink handling, sitecustomize, etc.

Therefore, this common behavior is extracted into a new "python_common" module, used by both plugins. This approach is also taken for the reference docs - the requirement of staging a Python interpreter is the same for both plugins.

Fixes #701

  • Have you signed the CLA?

The plugin has the same behavior and restrictions as the Python plugin with
regards to base-dependent behavior, symlink handling, sitecustomize, etc.

Therefore, this common behavior is extracted into a new "python_common"
module, used by both plugins. This approach is also taken for the reference
docs - the requirement of staging a Python interpreter is the same for both
plugins.

Fixes #701
@tigarmo tigarmo force-pushed the work/CRAFT-3362-rockcraft-poetry branch from 72a5337 to 8f28697 Compare September 26, 2024 20:04
@tigarmo tigarmo marked this pull request as ready for review September 26, 2024 21:13
@tigarmo tigarmo requested review from lengau and mr-cal and removed request for mr-cal September 26, 2024 21:13
Copy link
Collaborator

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The suggestion doesn't need to be done here, and can be rejected altogether if you don't like it.

@tigarmo tigarmo merged commit 422a2e9 into main Sep 27, 2024
10 checks passed
@tigarmo tigarmo deleted the work/CRAFT-3362-rockcraft-poetry branch September 27, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable the poetry plugin

4 participants