Skip to content

Conversation

@tigarmo
Copy link
Collaborator

@tigarmo tigarmo commented Oct 11, 2024

This commit also updates freeze-requirements to use 'pip-compile' instead of 'pip freeze'. The reason for this is that 'pip freeze' does not preserve the 'extras' of each dependency listed in the project's dependencies, which in this particular case is relevant for the 'canonical-sphinx[full]' change.

pip-compile also has the side-effect of showing where each transient dependency came from, which is very nice!

  • Have you signed the CLA?

@tigarmo tigarmo marked this pull request as ready for review October 11, 2024 22:27
@tigarmo tigarmo requested review from a team and lengau October 11, 2024 22:29
This commit also updates freeze-requirements to use 'pip-compile' instead of
'pip freeze'. The reason for this is that 'pip freeze' does not preserve the
'extras' of each dependency listed in the project's dependencies, which in
this particular case is relevant for the 'canonical-sphinx[full]' change.

pip-compile also has the side-effect of showing where each transient dependency
came from, which is very nice!
This feature isn't present on canonical-sphinx 0.1.0, and raises git-related
errors on our readthedocs builds.
@lengau lengau requested a review from a team October 12, 2024 11:32
@sergiusens sergiusens merged commit 9261dc7 into main Oct 14, 2024
15 checks passed
@sergiusens sergiusens deleted the work/update-deps branch October 14, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants