Feat(extension): Enable Async Gunicorn workers for Flask and Django e… #747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ile verification
…thethird/rockcraft into flask-django-extention-async-workers
…thethird/rockcraft into flask-django-extention-async-workers
…ithethird/rockcraft into flask-django-extention-async-workers
jdkandersson
approved these changes
Dec 10, 2024
tigarmo
requested changes
Dec 10, 2024
jdkandersson
approved these changes
Dec 11, 2024
tigarmo
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
thanks! @medubelko can you take a look at the updated docs and give the second review?
…thethird/rockcraft into flask-django-extention-async-workers
medubelko
requested changes
Dec 17, 2024
There was a problem hiding this comment.
@jdkandersson Apologies for getting to this so late. Let me know if I should clarify any of my suggestions. :)
medubelko
requested changes
Dec 18, 2024
There was a problem hiding this comment.
@alithethird Apologies for pinging the wrong person before. The fingers were moving too fast. 😓
I have one more small change and then I think we're good to merge.
Co-authored-by: Michael DuBelko <michael.dubelko@gmail.com>
Co-authored-by: Michael DuBelko <michael.dubelko@gmail.com>
|
@medubelko all good 👍 . Thanks a lot for your reviews :) |
medubelko
approved these changes
Dec 18, 2024
lengau
pushed a commit
to canonical/charmcraft
that referenced
this pull request
Jan 10, 2025
…go (#1986) Related to [Rockcraft PR](canonical/rockcraft#747) and [Paas Charm PR](canonical/paas-charm#11). Adds charm option to enable Async Gunicorn Workers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable Async Gunicorn workers for Flask and Django extensions
Reviewers:
@jdkandersson
@javierdelapuente
@tigarmo
@gregory-schiano